App
App copied to clipboard
Expensify
[$1000] cursor moves from right to left while opening search page
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- click on search icon
- check the cursor
Expected Result:
cursor should not move
Actual Result:
cursor moves from right to left
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android / native
- [ ] Android / Chrome
- [ ] iOS / native
- [x] iOS / Safari
- [ ] MacOS / Chrome / Safari
- [ ] MacOS / Desktop
Version Number: 1.2.78-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/222875041-6fa38053-3aee-4d76-8f75-584517af1ef3.MP4
https://user-images.githubusercontent.com/43996225/222875077-f211dd15-fda4-4519-b4e7-29cd9f6045fc.MP4
Expensify/Expensify Issue URL: Issue reported by: @hungvu193 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674752439760209
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0182cdb9e9ea4b8d61
- Upwork Job ID: 1633127293118607360
- Last Price Increase: 2023-03-07
Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Bug0 Triage Checklist (Main S/O)
- [ ] This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- [ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- [ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
Not overdue; I was assigned this while I was OOO. I will review this today.
Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)
Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.
Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to @stitesExpensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Cursor moves from right to left while opening search page.
What is the root cause of that problem?
Whenever search page open it will load OptionsSelector as shown below:
https://github.com/Expensify/App/blob/41eec3c513ea0cb1c433091692ea289e588040e0/src/pages/SearchPage.js#L185-L197
Eventually it will load BaseOptionsSelector component, and set text input focus during componentDidMount as shown here.
https://github.com/Expensify/App/blob/41eec3c513ea0cb1c433091692ea289e588040e0/src/components/OptionsSelector/BaseOptionsSelector.js#L102-L108
As we are not passing shouldDelayFocus props to OptionsSelector so it will set text input focus immediately as soon as component load, so cursor will focus to text field immediately and will move with transition. So this is the root cause of the problem.
What changes do you think we should make in order to solve the problem?
We have to pass shouldDelayFocus props to OptionsSelector component. i.e Add code within src/pages/SearchPage.js file as shown below:
<OptionsSelector
...
shouldDelayFocus // ** ADD THIS ***
/>
What alternative solutions did you explore? (Optional)
None
Result
https://user-images.githubusercontent.com/7823358/234919457-bf4c4c88-4660-4f8e-8490-7369f68a632b.mov
HI all, just checking, you want cursor be invisible while search window moves to the left or you want cursor stay to the left and move at the same time as search window loves?
📣 @mozai25! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
@stitesExpensify @isabelastisser we're working on the Search focus in https://github.com/Expensify/App/issues/15276. I went through the comment history, and considering it has some promising proposals, I think we should put this on Hold. I feel this would get resolved with the linked issue.
@mananjadhav, @isabelastisser, @stitesExpensify Eep! 4 days overdue now. Issues have feelings too...
I'll test this today and make sure that this is fixed, otherwise I will add the help wanted label
Doesn't look like this is fixed :/
https://user-images.githubusercontent.com/42391420/234969383-e71599d7-3f06-47f3-8b01-3375a47d36c4.mp4
@stitesExpensify my proposal https://github.com/Expensify/App/issues/15660#issuecomment-1458378032 above will solve this issue.