Enable Fabric and TurboModules on iOS & Android

[WoLewicki]

PR turning on the new architecture in the Expensify App as well as changing the libraries with native components to the commits containing implementation of Fabric integration in them.

Upstream PRs for the added patches

• https://github.com/react-navigation/react-navigation/pull/11806
• https://github.com/wonday/react-native-pdf/pull/803
• https://github.com/plaid/react-native-plaid-link-sdk/pull/557
• https://github.com/software-mansion/react-native-reanimated/pull/5588
• https://github.com/software-mansion/react-native-screens/pull/2024

Fixed Issues

$https://github.com/Expensify/App/issues/29258 PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

• [ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

• [ ] Verify that no errors appear in the JS console

PR Author Checklist

• [ ] I linked the correct issue in the ### Fixed Issues section above
• [ ] I wrote clear testing steps that cover the changes made in this PR
  • [ ] I added steps for local testing in the Tests section
  • [ ] I added steps for the expected offline behavior in the Offline steps section
  • [ ] I added steps for Staging and/or Production testing in the QA steps section
  • [ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [ ] I included screenshots or videos for tests on all platforms
• [ ] I ran the tests on all platforms & verified they passed on:
  • [ ] Android / native
  • [ ] Android / Chrome
  • [ ] iOS / native
  • [ ] iOS / Safari
  • [ ] MacOS / Chrome / Safari
  • [ ] MacOS / Desktop
• [ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [ ] I followed proper code patterns (see Reviewing the code)
  • [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [ ] I verified that comments were added to code that is not self explanatory
  • [ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • [ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • [ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [ ] I followed the guidelines as stated in the Review Guidelines
• [ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [ ] I verified that if a function's arguments changed that all usages have also been updated correctly
• [ ] If a new component is created I verified that:
  • [ ] A similar component doesn't exist in the codebase
  • [ ] All props are defined accurately and each prop has a /** comment above it */
  • [ ] The file is named correctly
  • [ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [ ] The only data being stored in the state is data necessary for rendering and nothing else
    • [ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [ ] All JSX used for rendering exists in the render method
  • [ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [ ] If any new file was added I verified that:
  • [ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [ ] If a new CSS style is added I verified that:
  • [ ] A similar style doesn't already exist
  • [ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[github-actions[bot]]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[WoLewicki]

I have read the CLA Document and I hereby sign the CLA

[AndrewGable]

6d97b2b is failing for web and desktop builds, however, here is iOS and Android testing links:

1. https://ad-hoc-expensify-cash.s3.amazonaws.com/android/13767/index.html
2. https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/13767/index.html

[j-piasecki]

I have read the CLA Document and I hereby sign the CLA

[kbecciv]

IOS - New Chat/New Group - The avatar jumps and flashes when opening a chat with a new user.

Action Performed:

1. Log in to NewDot with any type of account
2. Click on the green + button
3. Click on the "New Chat" option
4. Search for a user that you don't have any messages with and open the chat.

Expected Result:

Transaction should be smooth when opening a new group

Actual Result:

The avatar jumps and flashes when opening a chat with a new user.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] IOS / native

Version Number: 1.2.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/211158552-fd5e4896-fe9a-4102-9f8d-46e71a5f2076.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[kbecciv]

Android - Deeplink - The app doesn't open to the login screen. mWeb/Chrome is opened

Action Performed:

1. Log out of NewDot, if necessary.
2. Click to https://staging.new.expensify.com/concierge in your notepad

Expected Result:

User is not taken to the login screen

Actual Result:

User is taken to the login screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native

Version Number: 1.2.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/211161452-16aa8744-cb32-48a9-a9cf-303828ba0a10.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[kbecciv]

Android -Chat- First letter is shaking in composed box

Action Performed:

1. Scan the code and install the build
2. Log in with account
3. Select any use
4. Type first letter

Expected Result:

App should not be shaking

Actual Result:

First letter is shaking in composed box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native

Version Number: 1.2.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/211161704-a8da9fb5-1230-4ea7-ba91-0d210e9103cb.mp4

Issue reported by: Applause - Internal Team

[kbecciv]

Log in - Missing focus in Password field when log in with account

Action Performed:

1. Scan the code and install the build
2. In Log in put your email address
3. Tap Continue

Expected Result:

Focus should be displayed in Password field when log in with account

Actual Result:

Missing focus in Password field when log in with account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] IOS / Native

Version Number: 1.2.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/211161925-bfbec717-7cb0-4ba5-8744-115ed6e66fde.MP4

Issue reported by: Applause - Internal Team

[kbecciv]

IOS - Chat - Missing 'Expand' icon in the text input field

Action Performed:

1. Scan the code and install the app
2. Open ND app and login
3. Open any chat
4. Start typing multiple lines text in the input field

Expected Result:

There is an "Expand" icon in the upper left corner of the input field that expands the input field to full screen

Actual Result:

Missing 'Expand' icon in the text input field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] IOS / native

Version Number: 1.2.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/211163888-f2f87e76-2478-4e55-892b-6facf46ec83a.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

[kbecciv]

Android - Log in - The page blinks when tap "Go back" button"

Action Performed:

1. Open the App
2. Enter email in input field
3. Tap "Continue"
4. Tap "Go back"

Expected Result:

The page is not blink when tap "Go back" button"

Actual Result:

The page blinks when tap "Go back" button"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native

Version Number: 1.2.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/211164088-3d797a63-a699-466b-ad3c-9cab880ec007.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

[kbecciv]

Sign out - The blank page after tap sign out

Action Performed:

1. Open the App
2. Login with any account
3. Go to Settings - Sign out

Expected Result:

User sign out without blank page

Actual Result:

The blank page after tap sign out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android / native
• [ ] IOS / Native

Version Number: 1.2.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/211164203-930f7826-c36c-43e0-963c-64814d257426.mp4

Issue reported by: Applause - Internal Team

[kbecciv]

iOS - Second keyboard opens when you click on the cursor in Request money

Action Performed:

1. Launch App
2. Enter email. password
3. Click the FAB button and select Request Money
4. Verify that the big number pad (BNP) page appears next
5. Tab on the cursor next to currency

Expected Result:

There should be only one keyboard

Actual Result:

Second keyboard opens when you click on the cursor in Request money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] IOS / Native

Version Number: 1.2.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/211167008-8c333df1-912b-4a5f-8e9f-a16e2e457692.mp4

Issue reported by: Applause - Internal Team

[roryabraham]

New build successfully completed on all platforms ^

[roryabraham]

Going to run a new test build

[roryabraham]

Test build was unhappy: https://github.com/Expensify/App/actions/runs/4496222085

[mountiny]

https://github.com/Expensify/App/actions/runs/4745361495

[mountiny]

I triggered an internal build to try something

[OSBotify]

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/13767/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/13767/index.html
desktop :computer:	web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/13767/NewExpensify.dmg	https://13767.pr-testing.expensify.com

[melvin-bot[bot]]

@stitesexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop :computer:	Web :spider_web:
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the web build failed

---

:eyes: View the workflow run that generated this build :eyes:

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop :computer:	Web :spider_web:
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the web build failed

---

:eyes: View the workflow run that generated this build :eyes:

[ishpaul777]

Testing on simulator works? I do have a physical iphone but the build is never successful for me on my device requires additional permission and Apple Developer Account https://github.com/Expensify/App/pull/30374#issuecomment-1789680607

@mountiny

[mountiny]

@ishpaul777 yep you can test on simulators for this!

[ishpaul777]

Just finished building the IOS app, Adding all the issues found in testing in this comment.

1. Money request flow is broken

https://github.com/Expensify/App/assets/104348397/4481391d-41b4-49d8-ba0f-b2b663dae543

Crash on Clicking on any of the selector menu item for ex: Langauge selector menu item, prolly same RC with above, related to SelectionList

https://github.com/Expensify/App/assets/104348397/2fa1701e-85ca-45bc-a7ea-6895516cb4dd

2.BNP placeholder amount is misplaced sometimes

Screenshot

3. Calendar picker is invisible

Screenshot

5. clicking on "Photo" icon has no popover menuitems, when add receipt to a edit request

https://github.com/Expensify/App/assets/104348397/9f876a83-81c3-41bc-a779-b1d548a12447

[ishpaul777]

Android build Is sucessful but the App is stuck on splash screen

Screenshot

[mountiny]

testing the build with cleared cache https://github.com/Expensify/App/actions/runs/7630916526

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/13767/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/13767/NewExpensify.dmg	https://13767.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[WoLewicki]

@ishpaul777 can you check on this Android build from QR code? Maybe you didn't pull the newest commit when checking it before 🤞

[ishpaul777]

Works 🎉

[ishpaul777]

Android:

1. Popover Modals seems to be broken

Screenshot

2. LHN has different background, below the FAB

Screenshot

3. Composer is popped up with the keyboard when focussed

Video

https://github.com/Expensify/App/assets/104348397/c7faa85b-835c-4e49-9c7c-a73457fb94c9

4. Three dot menu popover background flashes when a option is selected

Video

https://github.com/Expensify/App/assets/104348397/442ea33b-c117-430b-9e18-df469f6a0171