Connect Bank Account - Endless loading is shown when navigate to Connect Bank Account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue was found when executing PR https://github.com/Expensify/App/pull/12634

Action Performed:

Precondition: Add VBA in Web for your testing account

1. Launch the app
2. Log in with your testing account
3. Navigate to Setting - Workspace - Workspaces
4. Tap Connect Bank Account

Expected Result:

Able to see message "You're all set!" under Connect Bank Account Page

Actual Result:

Endless loading is shown when navigate to Connect Bank Account

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.2.27.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/201385293-323d7261-3efe-40c0-8f13-d1d7b76891e2.MP4

https://user-images.githubusercontent.com/93399543/201385298-b4f020a5-fec0-4582-897a-da4f0d4ba3ea.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[kbecciv]

Checked in IOS production app and works fine, evidence attached

https://user-images.githubusercontent.com/93399543/201385513-7098ed42-30cb-4df7-acb6-808c0bd41e0f.MP4

[OSBotify]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Luke9389]

Investigating now.

[Luke9389]

The main branch did not have this problem at noon yesterday. Looking at the PRs merged since then....

[ctkochan22]

it may also be this PR? https://github.com/Expensify/App/pull/11751

[ctkochan22]

@kbecciv Which accounts were you using?

[Luke9389]

I'm also unable to reproduce on iOS dev.

[Luke9389]

Going to demote this until we can get more reliable reproduction steps.

[kbecciv]

@Luke9389 I used account: [email protected]. Reproduction steps:

1. Go to staging.new.expensify.com on Web
2. Go to Settings - Workspace
3. Select Connect Bank account
4. Select Plaid option
5. Select Fidelity option
6. Use credentials: user_good/pass_good
7. Select Saving account -1111
8. Use necessary information for Alberta Bobbeth Charleson (please ask if you don't have)
9. Finish to sets up the VBA
10. Go to IOS/Andriod app with the same account
11. Go Settings - Workspace -Connect Bank Account

[iwiznia]

I assume this must be broken because applause can reproduce and also is failing in another PR

[OSBotify]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ctkochan22]

@kbecciv Can we get the password?

[kbecciv]

@ctkochan22 [email protected] Password: Feya86Katya

[Luke9389]

Thanks for providing more detail on the reproduction steps @kbecciv

[Luke9389]

I'm blocked on this because I'm unable to skip the Onfido step on dev (not staging). @roryabraham @yuwenmemon

[Luke9389]

Hmm, I'm now experiencing the infinite spinner just after following the SO steps here (to create an OPEN bank account).

[Luke9389]

@kbecciv can you start with a fresh account and see if you get the same thing?

I did this: 3. To create an OPEN bank account (this state means the bank account is ready for reimbursement):

• Add Bank Account (On new dot enable Settings > Preferences > Use Secure staging server to hit our staging secure sandbox):

  • Click "Log into your bank"

  • Plaid modal - Choose Wells Fargo (use Bank of America if Wells Fargo is not available)

  • Plaid modal - User Id: user_good

  • Plaid modal - Password: pass_good

  • Plaid modal - Submit

  • Plaid modal - If they request a verification code via mobile sms, enter: credential_good when required

  • Choose an account: Plaid Saving11122XXXXXX111

  • Save & Continue

• Company Information (Enter anything unless specified):

  • Legal Business Name: Alberta Bobbeth Charleson

  • Company website: Enter any valid formatted website

  • Tax ID number: 123456789 (any nine digits)

  • Industry classification code: 123456 (any six digits)

  • Confirm company is not on list of restricted businesses

• Requestor Information (Enter anything unless specified)

  • First name: Alberta

  • Second name: Charleson

  • Toggle confirmation you are authorized to use company bank account

  • Save & Continue (Note: You will receive an error asking to "Please verify you name and date of birth". Hit "Save & Continue" again without changing any inputs.)

• Onfido (skipped)

• Beneficial Owners

  • Toggle terms and conditions

  • Toggle confirmation that the information provided is true and accurate

Once the modal closes, you're back at New Dot with an infinite loading spinner.

If this is happening for you too, then I think we should change this to say it's effecting all platforms (not just iOS).

[Luke9389]

Hmm, OK so it looks like the web spinner is happening when you add a VBA that you already have. This screenshot is from an earlier branch that doesn't have the spinner problem (so we can see the error). If you add a VBA successfully (say, on a totally new account, this doesn't happen).

[Luke9389]

I'm starting to suspect these might be two different infinite spinners. Testing the original post from above now that I have successfully linked a VBA. (i.e. I'm running iOS to see if the spinner occurs).

[Luke9389]

@kbecciv, when you set up the bank account, are you getting this at the end?

[Luke9389]

I was able to use different data to get passed the above screen, but now I'm stuck on this one (I've added a validated secondary login, and this still shows up).

[Luke9389]

When I run iOS, I also get the above screen. So far, I've not been able to reproduce this locally as described in the description. I haven't seen a single infinite spinner on iOS just yet.

[ctkochan22]

• Logs
  • Not much in the logs - Logs of App - Logs of Auth request
  • Free plan verified bank account found -- 1781402 but nothing else to indicate an infinite spinner specific to iOS
• Logging in and testing with applause tester's account.
  • Reproducable only on iOS

[kbecciv]

@Luke9389 Good day! What would you like me to check?

[ctkochan22]

@kbecciv Can you try again?

I was able to reproduce on your account earlier, but I am no longer able to.

[ctkochan22]

That's so strange that its no longer reproducible. Maybe it was fixed by a recent deploy. However, I've logged into the account and was not able to reproduce.

[roryabraham]

Since this is no longer reproducible, I'm going to demote it from deploy blocker to regular bug.

[melvin-bot[bot]]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[ctkochan22]

@kbecciv let us know if you can reproduce again. But so fart testing on that account we haven't been able to, where as a day ago we were able to. Going to close for now