App icon indicating copy to clipboard operation
App copied to clipboard

Deploy Checklist: New Expensify 2022-11-11

Open OSBotify opened this issue 3 years ago • 4 comments

Release Version: 1.2.27-3 Compare Changes: https://github.com/Expensify/App/compare/production...staging

This release contains changes from the following pull requests:

  • [ ] https://github.com/Expensify/App/pull/11751
  • [ ] https://github.com/Expensify/App/pull/12157
  • [ ] https://github.com/Expensify/App/pull/12181
  • [ ] https://github.com/Expensify/App/pull/12282
  • [ ] https://github.com/Expensify/App/pull/12373
  • [x] https://github.com/Expensify/App/pull/12391
  • [x] https://github.com/Expensify/App/pull/12498
  • [x] https://github.com/Expensify/App/pull/12513
  • [x] https://github.com/Expensify/App/pull/12545
  • [x] https://github.com/Expensify/App/pull/12548
  • [x] https://github.com/Expensify/App/pull/12579
  • [x] https://github.com/Expensify/App/pull/12604
  • [x] https://github.com/Expensify/App/pull/12606
  • [ ] https://github.com/Expensify/App/pull/12625
  • [ ] https://github.com/Expensify/App/pull/12628
  • [x] https://github.com/Expensify/App/pull/12631
  • [x] https://github.com/Expensify/App/pull/12634
  • [ ] https://github.com/Expensify/App/pull/12679
  • [ ] https://github.com/Expensify/App/pull/12688

Internal QA:

  • [x] https://github.com/Expensify/App/pull/12401 - @cead22 @dangrous

Deploy Blockers:

  • [x] https://github.com/Expensify/App/issues/12666
  • [ ] https://github.com/Expensify/App/issues/12670
  • [x] https://github.com/Expensify/App/issues/12671
  • [x] https://github.com/Expensify/App/issues/12687

Deployer verifications:

  • [ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • [ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

OSBotify avatar Nov 11 '22 02:11 OSBotify

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.27-0 :rocket:

OSBotify avatar Nov 11 '22 03:11 OSBotify

https://github.com/Expensify/App/pull/12401 can no longer be QAed so checking it off cc @cead22

dangrous avatar Nov 11 '22 22:11 dangrous

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.2.27-3 :rocket:

OSBotify avatar Nov 11 '22 22:11 OSBotify

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.27-3 has been deployed to staging :tada:

OSBotify avatar Nov 11 '22 23:11 OSBotify

Regression is completed

PR https://github.com/Expensify/App/pull/11751 is failing https://github.com/Expensify/App/issues/7270 and Native apps are blocked due to https://github.com/Expensify/App/issues/11796. Are we ok to check off? PR https://github.com/Expensify/App/pull/12157 is failing https://github.com/Expensify/App/issues/12637 https://github.com/Expensify/App/issues/12671 https://github.com/Expensify/App/issues/11961 https://github.com/Expensify/App/issues/11858 PR https://github.com/Expensify/App/pull/12181 is blocked by https://github.com/Expensify/App/issues/12530 PR https://github.com/Expensify/App/pull/12282 is pass on Web, but we are blocked to check on other platforms. Are we ok to check off? PR https://github.com/Expensify/App/pull/12628 does not have deeplink on Desktop app, rest platforms are pass. Checking off PR https://github.com/Expensify/App/pull/12688 all pass, but Android. App didnt update yet Checking CP https://github.com/Expensify/App/pull/12679. will update in the morning

mvtglobally avatar Nov 14 '22 02:11 mvtglobally

We also do not see the latest Android build 1.2.27-3

mvtglobally avatar Nov 14 '22 17:11 mvtglobally

Retrying Android deploy for 1.2.27-3

roryabraham avatar Nov 14 '22 18:11 roryabraham

Android 1.2.27-3 should be available now

roryabraham avatar Nov 14 '22 19:11 roryabraham

Checking off https://github.com/Expensify/App/pull/12679 & https://github.com/Expensify/App/pull/12688

Outstanding items PR https://github.com/Expensify/App/pull/11751 is failing https://github.com/Expensify/App/issues/7270 and Native apps are blocked due to https://github.com/Expensify/App/issues/11796. Are we ok to check off? PR https://github.com/Expensify/App/pull/12157 is failing https://github.com/Expensify/App/issues/12637 https://github.com/Expensify/App/issues/12671 https://github.com/Expensify/App/issues/11961 https://github.com/Expensify/App/issues/11858 PR https://github.com/Expensify/App/pull/12181 is blocked by https://github.com/Expensify/App/issues/12530 PR https://github.com/Expensify/App/pull/12282 is pass on Web, but we are blocked to check on other platforms. Are we ok to check off?

mvtglobally avatar Nov 15 '22 01:11 mvtglobally

:clap: Heads up @Expensify/applauseleads :clap: A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.2.27-4 :rocket:

OSBotify avatar Nov 15 '22 10:11 OSBotify

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.27-4 has been deployed to staging :tada:

OSBotify avatar Nov 15 '22 11:11 OSBotify

Checking off https://github.com/Expensify/App/pull/12722

mvtglobally avatar Nov 15 '22 19:11 mvtglobally

Timing graphs are a bit all over the place but we seem to be on a downward trend, and there was a post-mortem sent out yesterday for a performance regression that has been fixed, so we should be okay to deploy.

roryabraham avatar Nov 15 '22 20:11 roryabraham

No new crashes in this version either:

image

roryabraham avatar Nov 15 '22 20:11 roryabraham

:shipit:

roryabraham avatar Nov 15 '22 20:11 roryabraham