App icon indicating copy to clipboard operation
App copied to clipboard

"Crash" issues - clean-up and next steps

Open trjExpensify opened this issue 3 years ago • 6 comments

Coming from this discussion.

  • [ ] Only open a "crash" issue after it happens more than 10 times
  • [ ] For existing crashes logged, update the reopen logic to see if the crash count is less than 10 before reopening
  • [ ] Remove the $500 price cap on crash issues
  • [ ] Implement source maps to aid with investigating these issues (GH)
  • [ ] Close the loop on people running staging builds locally sending false positives (GH)
  • [ ] Improve the documentation for how to approach these issues, and link the readme in the crash issue creation template

CC: @AndrewGable @JmillsExpensify @michaelhaxhiu @roryabraham

trjExpensify avatar Nov 09 '22 20:11 trjExpensify

Should we throw a Bug label on this, on someone assign themself? I'm thinking yes since some of those todos are BZ tasks.

JmillsExpensify avatar Nov 09 '22 21:11 JmillsExpensify

I don't think it's a bug really, it's a process improvement.

I'll assign myself anyway and take on this one:

Remove the $500 price cap on crash issues

trjExpensify avatar Nov 09 '22 21:11 trjExpensify

Ok cool. Mainly I think someone from BZ should assign themselves.

JmillsExpensify avatar Nov 10 '22 04:11 JmillsExpensify

There's already an issue for the source maps https://github.com/Expensify/App/issues/9293 Not sure if we want to close that out or remove that part from this isssue. FWIW I think adding the source map should be the first step, because without it, some crashes are impossible to diagnose.

iwiznia avatar Nov 10 '22 10:11 iwiznia

It's linked to this issue in the OP.

trjExpensify avatar Nov 10 '22 11:11 trjExpensify

Focused on the source maps as the first priority for this, then will get to this.

AndrewGable avatar Nov 12 '22 00:11 AndrewGable

Closing per https://github.com/Expensify/Expensify/issues/243479, tl;dr we are turning off Firebase crashes for the time being.

AndrewGable avatar Nov 16 '22 22:11 AndrewGable