App icon indicating copy to clipboard operation
App copied to clipboard

Chat - Two editing windows open at the same time

Open kbecciv opened this issue 3 years ago • 3 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open the App
  2. Log in with any account
  3. Open any chat
  4. Kill the internet connection
  5. Send the message
  6. Turn on the Internet
  7. Click on the last message and choose "Edit comment"

Expected Result:

Only one editing window should be open at the same time

Actual Result:

Two editing windows open at the same time

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.2.20.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/198368986-44911ff5-fcbb-4ad2-b217-2fc22deac51d.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

kbecciv avatar Oct 27 '22 18:10 kbecciv

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Oct 27 '22 18:10 melvin-bot[bot]

@davidcardoza Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Oct 31 '22 07:10 melvin-bot[bot]

@davidcardoza Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Oct 31 '22 08:10 melvin-bot[bot]

I was able to reproduce on iOS. Moving this to external.

davidcardoza avatar Nov 01 '22 04:11 davidcardoza

Current assignee @davidcardoza is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Nov 01 '22 04:11 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

melvin-bot[bot] avatar Nov 01 '22 04:11 melvin-bot[bot]

Triggered auto assignment to @thienlnam (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] avatar Nov 01 '22 04:11 melvin-bot[bot]

Pending proposals

thienlnam avatar Nov 01 '22 18:11 thienlnam

Heyo @davidcardoza, just dropping a note as a reminder to keep the pressure on to find a contributor and get this one closed out :)

Has this job been posted to upwork yet? If not, let's do that as a first step here to increase visibility of this job posting to the public.

michaelhaxhiu avatar Nov 03 '22 22:11 michaelhaxhiu

@davidcardoza, @rushatgabhane, @thienlnam Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Nov 07 '22 08:11 melvin-bot[bot]

I wanted to give a reproduction test (to possibly submit a proposal) but getting this issue when building on ios/android. Any guesses what might be causing this?

huzaifa-99 avatar Nov 07 '22 11:11 huzaifa-99

I have been OOO. Job posted - https://www.upwork.com/jobs/~0183e621ff73890860

davidcardoza avatar Nov 08 '22 01:11 davidcardoza

Hey @huzaifa-99, please keep all setup/configuration issues in #expensify-open-source channel so we can keep the discussion specific to this issue only

thienlnam avatar Nov 08 '22 20:11 thienlnam

Waiting for proposals, cc @davidcardoza could we double this issue?

thienlnam avatar Nov 11 '22 18:11 thienlnam

@davidcardoza, @rushatgabhane, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Nov 15 '22 08:11 melvin-bot[bot]

Price doubled to $500

davidcardoza avatar Nov 16 '22 13:11 davidcardoza

@thienlnam To help us clear out the large backlog of /App bugs, we're putting the spotlight every bug in the repo already than 4 weeks old. To help unblock the roadmap and get our bug pipeline back in equilibrium, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is
  • For any that can't, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #bug-zero

puneetlath avatar Nov 17 '22 21:11 puneetlath

Can't seem to reproduce, is this still valid? The issue seems more like: Message is sent twice. The edit behaviour is only a result of two messages having the same sequence id I suppose.

s77rt avatar Nov 19 '22 13:11 s77rt

This actually should be solved by sequence numbers so I'm going to go ahead and close it. @davidcardoza @thienlnam feel free to reopen if you disagree.

Thanks for looking into everyone. Looking forward to having you contribute on other issues.

puneetlath avatar Nov 19 '22 16:11 puneetlath