App icon indicating copy to clipboard operation
App copied to clipboard
verified publisher icon Expensify

Payment - An incorrect bank error message displayed

Open kbecciv opened this issue 3 years ago • 4 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/11839

Action Performed:

  1. Go to URL https://staging.new.expensify.com/and login
  2. Go to settings > Payments > Add payment method
  3. Bank account > Plaid flow
  4. While in Plaid Sandbox mode, enter any data
  5. You'll be brought back to Expensify
  6. Select a bank account in the dropdown
  7. Use a wrong password > Click Save & continue
  8. Verify the error says "An unexpected error occurred while trying to add your bank account. Please try again."

Expected Result:

We should see "An unexpected error occurred while trying to add your bank account. Please try again" error message

Actual Result:

An incorrect bank error message displayed

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.19.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/197916413-6c1061ca-b2ec-4c92-9598-c5358a6c7c60.mp4

Screen Shot 2022-10-25 at 3 30 18 PM

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

kbecciv avatar Oct 26 '22 01:10 kbecciv

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] avatar Oct 26 '22 01:10 melvin-bot[bot]

Hi, it's not a bug. Because of adding new validation you are seeing this error message which is expected. Now you won't see the error message mentioned at https://github.com/Expensify/App/pull/11839 unless the api fails.

Puneet-here avatar Oct 26 '22 10:10 Puneet-here

@yuwenmemon Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Oct 31 '22 07:10 melvin-bot[bot]

@yuwenmemon Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Oct 31 '22 08:10 melvin-bot[bot]

Yes we just need to update the TestRail steps cc @Expensify/applauseleads

Incorrect Expensify password entered is the expected error message now for those test steps.

Closing this out! Let me know if you need me to create a separate issue for updating the test steps.

yuwenmemon avatar Oct 31 '22 14:10 yuwenmemon