App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Web - Connect Bank Account - User can proceed to Company Information page without clicking the checkmark "I accept the Expensify term of service"

Open kbecciv opened this issue 2 years ago • 7 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Log in with a applause.expensifail account (that does not have any bank account already added)
  2. Enable staging Web secure server in Account Preferences if disabled
  3. Navigate to the add bank account modal (Workspace settings > Add bank account)
  4. Verify the Add bank account modal is displayed with 2 options to add bank accounts (Log in and Manual)
  5. Select the Connect with plaid method to add a bank account
  6. On the bank account list select "Chase"
  7. You'll be redirected to the "First Platypus Bank"
  8. Enter the credentials "user_good / pass_good"
  9. If a verification is prompted - select mobile and enter "credentials_good" as the verification mode
  10. Checkmark the "Plaid Checking" and "Plaid Saving"
  11. Checkmark the 2 options under "additional information you want to share"
  12. Click on continue
  13. Check the T&C and click "Connect account information"
  14. Click on the last confirmation on the plaid modal
  15. Verify you're redirected to the choose an account screen in NewDot
  16. Select the bank account ending in 1111
  17. Verify you're redirected to the enter back account details manually (this is a special case for the Chase bank account selection)
  18. Enter a incorrect bank account number (e.g 1111222233334444)
  19. Verify there's an error for entering the wrong bank account and in which number should the bank account end with.
  20. Enter the correct number - 1111222233331111
  21. Verify you can proceed and the next step in the bank account flow is displayed
  22. Close the modal
  23. Go back to Setting - Workspace
  24. Select Connect Bank Account
  25. Verify you're redirected to the enter back account details manually
  26. Do not select the checkmark "I accept the Expensify term of service" 28 Click Save and Continue

Note:

mWeb - Using the Chase credentials does not work. We are blocked to test the VBA flow in app, it directed to production.

Expected Result:

User can not proceed to Company Information page without clicking the checkmark "I accept the Expensify term of service"

Actual Result:

User can proceed to Company Information page without clicking the checkmark "I accept the Expensify term of service"

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS - blocked
  • Android - blocked
  • Desktop App -n/a
  • Mobile Web - blocked to

Version Number: 1.2.18.10

Reproducible in staging?: Yes

Reproducible in production?: N/A

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/197649633-31b0327f-ab45-4a96-900e-d6020cebd4d9.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

kbecciv avatar Oct 24 '22 22:10 kbecciv

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] avatar Oct 24 '22 22:10 melvin-bot[bot]

Triggered auto assignment to @ntrepanier (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot[bot] avatar Oct 27 '22 14:10 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

melvin-bot[bot] avatar Oct 27 '22 14:10 melvin-bot[bot]

Current assignee @tgolen is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Oct 27 '22 14:10 melvin-bot[bot]

Marking as external to start getting proposals

tgolen avatar Oct 27 '22 14:10 tgolen

@tgolen, @ntrepanier, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Oct 31 '22 07:10 melvin-bot[bot]

@tgolen, @ntrepanier, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Oct 31 '22 08:10 melvin-bot[bot]

No Takers.

parasharrajat avatar Oct 31 '22 12:10 parasharrajat

I tried reproducing the issue in my local system, but instead of opening the 'First Platypus Bank' modal, it is getting redirected to this URL - https://secure06ea.chase.com/web/auth/thirdparty/authorize?... I tried using user_good / pass_good credentials, but it throws an Unauthorized error - "We can't find that username and password."

What I might be missing here? @kbecciv @parasharrajat

Screenshot 2022-10-31 at 5 13 51 PM

mmjindal2555 avatar Oct 31 '22 12:10 mmjindal2555

@mmjindal2555 Are you our Slack? If not, please request access and it would be a good question there.

parasharrajat avatar Oct 31 '22 13:10 parasharrajat

I have requested access, waiting for it.

mmjindal2555 avatar Oct 31 '22 13:10 mmjindal2555

Meanwhile, raised it here https://expensify.slack.com/archives/C01GTK53T8Q/p1667222549786869.

parasharrajat avatar Oct 31 '22 13:10 parasharrajat

Thank you @parasharrajat, I was able to redirect to the Sandbox webpage for the Bank verification. However, for me, the behavior seems to be as expected, i.e., I am getting the error prompt when the Terms checkbox is not selected on submitting.

Version Number (Dev): 1.2.21-4 - working as expected Version Number (Staging): 1.2.22-3 - working as expected

Another difference I noticed - Error raised on Wrong Account number in OP's video - And unexpected error occurred...

Error raised in my iterations - Your account number should end with 1111

@kbecciv @parasharrajat

Recording - https://user-images.githubusercontent.com/14273484/199331539-01967bce-c356-409f-9b9a-4f3c6ab0ee57.mp4

mmjindal2555 avatar Nov 01 '22 20:11 mmjindal2555

It might have been fixed by now. @Expensify/applause Could you please retest this issue?

parasharrajat avatar Nov 01 '22 21:11 parasharrajat

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Nov 03 '22 03:11 mvtglobally

@parasharrajat Issue is fixed.

https://user-images.githubusercontent.com/43996225/199737606-5279d7a3-fb3f-4f7d-84a1-816918bd38a4.mp4

kavimuru avatar Nov 03 '22 13:11 kavimuru

Good to close then.

parasharrajat avatar Nov 03 '22 13:11 parasharrajat

@tgolen, @ntrepanier, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Nov 07 '22 08:11 melvin-bot[bot]

Closing this out now.

tgolen avatar Nov 07 '22 15:11 tgolen