Fix navigation on Welcome event

[luacmartins]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. 1. Create a new workspace from an account that's on the policyExpenseChat beta (e.g @expensifail.com)
2. Add a new member to the workspace via Manage Members > Invite
3. CMD+F and search the member's name to navigate to their workspace chat
4. Write a couple of messages in the member's workspace chat, then log-out of the admin account
5. Validate the member account and log-in to NewDot
6. Observe that you land in the Concierge DM and not the member's workspace chat

Expected Result:

User should be navigated to the correct chat

Actual Result:

User is not navigated to the correct chat

Workaround:

Manually navigate to the chat

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

[luacmartins]

Coming from this comment, it seems like iOS and android are experiencing some quirk with react navigation.

[melvin-bot[bot]]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[techievivek]

Will look into it this week.

[techievivek]

Not overdue.

[techievivek]

I think this might get fixed here

[techievivek]

I will follow the conversation there and see if that would also fix the navigation issue for this case or not.

[techievivek]

I was ooo so looking into it today.

[techievivek]

Seems like the drawer is open and maybe that's why sometime users are not navigated to the workspace chat.

I just tested this and though the drawer state is open it did navigate me to the workspace chat.

I will test it a few more just to be sure and then I will add this issue on HOLD because with navigation refactor this will be automatically fixed as we are switching to stack-based navigation.

[techievivek]

Tested this couple of times and every time it navigated to workspace chat on Android though the drawer state was open.

@luacmartins Do you mind giving it a try just to see if this still happens? Thanks

[luacmartins]

I just tested and it seems like this doesn't work at all anymore on any platform 😢 Looking at the logs, it seems like we are never setting ONYXKEYS.IS_LOADING_REPORT_DATA to false here. Am I missing something?

[techievivek]

This is weird, it worked perfectly for me. This is what I did.

1. Invited a new user to a workspace which created a chat between admin and newly invited user.
2. Added some messages for the invited user in the workspace chat.
3. Logged out from the admin account.
4. Validated the invited user account and logged in to newDot.
5. It right away took me to workspace chat.

I will a screen share recording tomorrow.

[techievivek]

Sorry, I couldn't get time to look into it today. I will share a recording tomorrow for sure.

[techievivek]

Here is a video of it.

https://user-images.githubusercontent.com/35863227/205582148-0fdc51b0-f22a-45e9-b713-52918b65fa23.mov

[techievivek]

@luacmartins Can you please have a look at the video and try this once again.

[luacmartins]

@techievivek it seems to be working for me now 😕

https://user-images.githubusercontent.com/22219519/206230741-2e66a430-170c-41c6-9771-27e1e8f3e689.mov

[techievivek]

🤣 Yeah, it seems inconsistent. I will add this issue under Navigation reboot and will tackle this once the navigation reboot is implemented.

[techievivek]

Not overdue, we are holding this for App navigation reboot.

[techievivek]

It's on hold for the navigation reboot project.

[trjExpensify]

I ran some end-to-end retests on workspace chats today and this worked fine for me as well. I think there are a few instances just broadly with inconsistent navigation on sign-in, agree with this call to hold on the nav reboot.

[techievivek]

On hold for navigation reboot project.

[techievivek]

On hold for navigation reboot project.

[techievivek]

On hold for navigation reboot.

[techievivek]

On hold for navigation reboot. We are making good progress on the project, so hoping to test and close this soon.

[techievivek]

On hold for navigation refactor.

[JmillsExpensify]

Adding myself on this one now that the navigation refactor is complete and I need to re-test.

[JmillsExpensify]

Alright, I just re-tested this one and I successfully landed in the workspace chat. Now I do land in the Concierge chat if I'm not on the beta, policyExpenseChat beta, but otherwise it works like a charm now. I'm going to close this issue, though please re-open if anyone disagrees.

[trjExpensify]

Didn't seem to work for me as a new member:

[techievivek]

We can send it back to the contributors, I am pretty sure they should be able to fix this up in case this is reproducible.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~012abff40d9e607123

[melvin-bot[bot]]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.