App
App copied to clipboard
Expensify
BUG: default avatar different for new chat and In LHN reported by @gadhiyamanan
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- click on :green-plus-button: icon
- select new chat
- search for random new user ( like [email protected])
- check the avatar (avatar background color)
- click on the user to initiate conversation
- check the avatar (avatar background color) on the conversation or LHN
Expected Result:
default avatar should be same while searching for new chat and LHN
Actual Result:
default avatars are different
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.2.18-2 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/196825164-55d43099-5b26-40a9-b9c4-e05e113621d0.mov
Expensify/Expensify Issue URL: Issue reported by: @gadhiyamanan Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666160339859479 View all open jobs on GitHub
https://user-images.githubusercontent.com/43996225/196825188-60c818f5-3aa9-4bc3-8b60-7ff5c99463ac.mp4
Triggered auto assignment to @ntrepanier (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
I tried to recreate the issue following the listed steps on android and web in both production and staging but could not reproduce.
@ntrepanier Huh... This is 4 days overdue. Who can take care of this?
@ntrepanier Huh... This is 4 days overdue. Who can take care of this?
@ntrepanier 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
Just noticed that there are some issues assigned to @ntrepanier , reapplying the AutoAssignerTriage!
Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
I would recommend we not fix this. It's not really a "bug" and an intentional behavior that we've had for a long time. If there's no avatar to use a random avatar is generated. The fact that it is changing color doesn't feel like a real problem we need to solve and fixing it brings very little value.
A Contributor Manager will be assigned to issue payment via Upwork if we deploy an associated Pull Request to production. Per Contributing.md.
@aldo-expensify I think this is related to the change here https://github.com/Expensify/App/pull/11400
The server is still sending a md5 hash
https://github.com/Expensify/Web-Expensify/blob/03510d77cd89d1cd6311bd9189e4c4306d97612b/lib/User/Utils.php#L327-L333
But in the client we are doing something else so the avatar colors change now.
I think this may be the equivalent function in php: https://stackoverflow.com/a/15702546/16434681
So @marcaaron - did we decide we're going to fix this or this is intended behaviour?
I am sideways thumb on whether this is worth prioritizing (we just have so many more important issues to work on right now). But, maybe a good first pick issue to do eventually? Doesn't feel like an urgent Bug so I think we can just get to it when we get to it.
I might be able to fix this while I implement the new avatars for new dot, I think we just need to match the hashing function in Web with the one in App. Mind if I assign for now @marcaaron ?
What are we on hold for @grgia? Mind linking the GH its dependent on? That way we can close this issue and reopen it once the other is done
I was holding the avatar changes to complete core branding changes first. However that's almost done, so I should be able to work on avatar fixes again
This issue has not been updated in over 15 days. @grgia, @sophiepintoraetz eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
closing as completed, since no longer occurs with the new default avatars on new dot!