[$1000] iOS - Unread LHN - Unread username unbolded after minimize or open command center

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Run NewDot App
2. Open LHN and receive new msg while focused on the tab
3. Minimize App or open Command center few times

Expected Result:

Unread indication functionality should works without any issues at LHN tab

Actual Result:

If the user focused on the LHN tab and new msg is received: App minimising or opening command center will lead to unbold username at the LHN tab

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.2.17.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/196318472-54550aed-4e91-4185-8006-dc9c4503182c.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bondydaa]

hmm strange! tossing to the pool, I don't think this need to be a daily but def isn't great UX.

[melvin-bot[bot]]

Triggered auto assignment to @muttmuure (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[muttmuure]

I think this needs the External label, we've engineering reviewed and triaged out of order

[melvin-bot[bot]]

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot[bot]]

Triggered auto assignment to @iwiznia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[muttmuure]

I'm getting an error when I try to post to Upwork. I've raised it in #bugzero https://expensify.slack.com/archives/C01SKUP7QR0/p1666183255766669

[muttmuure]

Just needed to wait a little bit and now it's posted

[muttmuure]

The job is here https://www.upwork.com/jobs/~01b43085bb2505c069

[chauchausoup]

I think this issue was reported first in here by me : https://github.com/Expensify/App/issues/11514

[thesahindia]

I don't see any similarities. It's a different issue.

[muttmuure]

Price has been doubled to $500

[iwiznia]

Should we double again?

[muttmuure]

Price has been doubled to $1000 - will cross post to Slack.

[melvin-bot[bot]]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[thesahindia]

~The proposal looks good at first glance but I won't be able to look much into it right now (4 AM for me) will look into it ASAP in the morning.~

[thesahindia]

~The proposal looks good at first glance~ Taking my words back, it doesn't look good after looking into the issue.

@railway17, I am little lost here. I am not sure how your proposal solves this issue, can you confirm the issue? Also can you share a video after the fix?

[thesahindia]

I found that if you mark the last message as unread and refresh the page then the chat gets read.

https://user-images.githubusercontent.com/83179295/200791424-bc08dffa-2c80-4722-b0a3-288e75809e27.mov

Steps:-

1. Navigate to any chat
2. Mark the last message as unread
3. Observe that the username is bold
4. Navigate to a different chat
5. Refresh the page
6. Observe that the username is not bold anymore

@iwiznia, should we include it in this issue or should I post this on slack.

[railway17]

I found that if you mark the last message as unread and refresh the page then the chat gets read.

1. Navigate to any chat
2. Mark the last message as unread
3. Observe that the username is bold
4. Navigate to a different chat
5. Refresh the page
6. Observe that the username is not bold anymore

Actually, this issue is reported with the reproducible platform - iOS. So, I tested on mobile platforms (in both iOS and Android) and checked what is working. But I missed the testing case with Mark as Unread. Just tested by sending a new message from another user. I will update you with videos for both cases.

[railway17]

@thesahindia https://drive.google.com/file/d/1mcirZLECKnUCn-tWBT-d9fsmLk0fp_PS/view?usp=sharing

Here is the video for fixing issue when the user received the new message. This video is produced from my proposal code.

On the other hand, I've tested with Mark as Unread. But looks like it is caused by another reason. I will catch it up and update you.

[thesahindia]

It's really strange, I was able to repro this in the morning (on android and ios both) but I can't repro it anymore. @kbecciv, can you test this again?

[railway17]

It's really strange, I was able to repro this in the morning (on android and ios both) but I can't repro it anymore. @kbecciv, can you test this again?

It's able to be reproduced if you go through Report page > back to LHN > send message from another device > minimize > open. If user entered into Report page, unsubscribeVisibilityListener listener will be created in the componentDidMount. But it will not be unsubscribed when go back to LHN page as I mentioned. Because of it, issue would be produced

[thesahindia]

Still no luck.

https://user-images.githubusercontent.com/83179295/201019649-54e31de1-c7d7-42b0-9553-001134cadfd5.mp4

Also I am facing another issue. Chat isn't getting bold when receiving message while I am at LHN

https://user-images.githubusercontent.com/83179295/201020531-30e4fd98-7b24-41a1-b627-211dfb66f499.mov

[railway17]

Also I am facing another issue. Chat isn't getting bold when receiving message while I am at LHN

@thesahindia Are you referring, you got another issue if you use my above proposal code? 🤔

[thesahindia]

@thesahindia Are you referring, you got another issue if you use my above proposal code? 🤔

No, I am seeing this issue on production as well.

[railway17]

No, I am seeing this issue on production as well.

Ok, I also checked it is in production. But my above proposal will resolve this issue for new messages. But is not working for Mark as Unread. I am still debugging for it, and noticed that there is some strange actions for updating Onyx data.

[thesahindia]

But is not working for Mark as Unread.

I was only able to repro this issue by using Mark as Unread. I think the solution should work for Mark as Unread case too.

Who can give me a full answer to my question regarding Onyx?

You can ask Onyx related questions at #expensify-open-source

[railway17]

was only able to repro this issue by using Mark as Unread. I think the solution should work for Mark as Unread case too.

Yes, I agree with it and still debugging for it 😓

You can ask Onyx related questions at #expensify-open-source

Thank you

[railway17]

@thesahindia Which channel do I need to use to ask the API command problem? Need to ask in the #expensify-open-source channel through slack?