App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2022-10-31] Software keyboard hides when you scroll the chat

Open roryabraham opened this issue 3 years ago • 8 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open a chat
  2. Click on the compose input to open the keyboard
  3. Scroll the chat

Expected Result:

The keyboard should stay open.

Actual Result:

The keyboard closes.

Workaround:

None, this is a pain point for users and a critical regression.

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Mobile Web

Version Number: 1.2.16-4 Reproducible in staging?: yes Reproducible in production?: yes Email or phone of affected tester (no customers): n/a Issue reported by: (I don't know their GH name) Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665991322162069

View all open jobs on GitHub

roryabraham avatar Oct 17 '22 17:10 roryabraham

Previously, we added this so that the user is able to see the whole list instead of a few items.

So the thought was that if a user is trying to scroll the list, the user probably wants to see the items below the keyboard. This kind of helped on small screens.

parasharrajat avatar Oct 17 '22 17:10 parasharrajat

Working on this ... currently blocked by infra process here. Once that's done hopefully we can push this forward quickly

roryabraham avatar Oct 17 '22 20:10 roryabraham

Currently blocked on https://github.com/Expensify/Expensify/issues/234445

roryabraham avatar Oct 17 '22 21:10 roryabraham

WIP PR: https://github.com/Expensify/App/pull/11944

roryabraham avatar Oct 17 '22 23:10 roryabraham

PR ready for review. I'm choosing not to CP it so that it gets to undergo a full regression suite.

roryabraham avatar Oct 18 '22 00:10 roryabraham

I will open this to pay @aimane-chnaif for reporting this in Slack first https://expensify.slack.com/archives/C01GTK53T8Q/p1665991623386559?thread_ts=1665991322.162069&cid=C01GTK53T8Q

mountiny avatar Oct 24 '22 10:10 mountiny

Assigning @dylanexpensify who kindly agreed to help out with paying out this bonus to @aimane-chnaif in weeks time

mountiny avatar Oct 24 '22 10:10 mountiny

Thanks @mountiny @dylanexpensify

aimane-chnaif avatar Oct 24 '22 10:10 aimane-chnaif

@aimane-chnaif here's the job post for you to apply!

dylanexpensify avatar Oct 31 '22 11:10 dylanexpensify

@dylanexpensify applied

aimane-chnaif avatar Oct 31 '22 11:10 aimane-chnaif

Offer sent @aimane-chnaif !

dylanexpensify avatar Oct 31 '22 12:10 dylanexpensify

Payment sent, contract ended, posting closed

dylanexpensify avatar Oct 31 '22 12:10 dylanexpensify