App
App copied to clipboard
Expensify
[$250] BUG: Workspace room name input not grayed out when pending update fails
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- Sign in with any account
- Create a workspace from the green plus (if needed)
- Create a workspace room from the green plus (if needed)
- Go offline
- Click the header of the workspace room to open the room details page
- Click "Settings"
- Rename the room (
#examplerename) and hit save - Verify that the input is grayed out (50% opacity)
- Sign into the same account on another device or incognito window
- Create another workspace room on the same workspace with the same name (
#examplerename) - Go back to the other device and go back online
- Verify that there is a red dot and an error message saying "A room with this name already exists".
- Verify that there is a red dot on the LHN
Expected Result:
The inputs on the workspace settings page are grayed out (50% opacity)
Actual Result:
The inputs on the workspace settings page are not grayed out (50% opacity)
Workaround:
Ignore it.
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: v1.2.15-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @neil-marcellini Slack conversation:
Triggered auto assignment to @ntrepanier (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm OOO for the next couple days driving home so I'm reassigning so this gets looked at properly.
Triggered auto assignment to @MitchExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
@neil-marcellini when you say "Verify that the input is grayed out" in step 8, where are you referring to? I see the input is not grayed after sacing in this example if you are referring to the text field input:
Verify that the input is grayed out:
I have updated the steps to clarify that both inputs should be grayed out (50% opacity). They will only be grayed out if you are offline and you have saved an updated workspace name. It should look like this, which I just tested on prod.
I simplified the reproduction steps so hopefully they are more clear now.
Reproduced:
This is probably a good external candidate right @neil-marcellini ?
This is probably a good external candidate right @neil-marcellini ?
Yep. I looked at the code a bit myself and I'm actually not sure why it isn't working right now. I don't think it will require any backend changes. The errors and pendingAction passed to OfflineWithFeedback are set correctly, but for some reason the opacity is not applied. https://github.com/Expensify/App/blob/83676c1036299ffecbf82f4b829a7f8cbd741cd7/src/pages/ReportSettingsPage.js#L165-L169
Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)
Triggered auto assignment to @Luke9389 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@parasharrajat, @MitchExpensify, @Luke9389 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@parasharrajat, @MitchExpensify, @Luke9389 Whoops! This issue is 2 days overdue. Let's get this updated quick!
We should consider taking this one internal, as it's blocking a test script from being added to TestRail. In the meantime, maybe doubling the price again will help encourage contributor proposals!
Once I'm done with my current bug, I'll come back if this one is still up for grabs.
@neil-marcellini @Luke9389 @parasharrajat I am trying to reproduce the BUG. After doing Step 7, the input is grayed out (50% opacity) and this is expected result. Can you please help me to understand the bug.
https://user-images.githubusercontent.com/111683206/201394320-261e13ba-59d0-4e18-8484-10f73ceba7e9.mov
I am also confuse a bit here. what does the workspace settings page has to do with Room renaming?
The inputs on the workspace settings page are grayed out (50% opacity)
And when should this happen? after which step?
cc: @neil-marcellini
The inputs on the workspace room settings page are grayed out (50% opacity)
We're missing the word room in the expected/actual result, but that's the meaning as it's also the language used in the reproduction steps.
And when should this happen? after which step?
The reason that this should happen is that the app is offline in this state, and this is a "pending action" which cannot be saved until the app comes back online. Here's another example for the workspace settings page, simply because I have that mock handy. Notice the second input? That's what we should be going for.
Ok, so you are saying that input should be grayed out in below image. I got confused but the expected and actual result as well as https://github.com/Expensify/App/issues/11914#issuecomment-1285884724
Ok, so you are saying that input should be grayed out in below image
Yes, exactly.
@neil-marcellini Are you saying that the notification preferences (first input) should be greyed out? I would have thought that's Pattern A (no failure case offline), but maybe there's a case you have in mind.
The name input on the workspace room settings page should be grayed out when there was an error updating it. I'll edit the issue description to make it more clear.
@Luke9389 Hows your bandwidth looking at the moment for this one to take it internally?
@varshamb So the issue is asking that at step 13 as well as the red dot.