[HOLD for payment 2022-11-09] [$250] Bug: Space after emoji doesn't get added for edit field like main composer reported by @Puneet-here

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open any chat > Send message > Edit
2. Click on emoji button and select an emoji

Expected Result:

The space should be added after emoji like composer

Actual Result:

Space doesn't get added after adding emoji

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.14-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: https://user-images.githubusercontent.com/43996225/195677511-af2c2bc9-0443-44db-bcd3-37445b0206b6.mp4 https://user-images.githubusercontent.com/43996225/195677500-769c3c7d-6497-4561-91c5-6dd2b328e982.mov Expensify/Expensify Issue URL: Issue reported by: @Puneet-here Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665670095261569

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Puneet-here]

Proposal

We need to add a new variable emojiWithSpace and need to use it like this:

    addEmojiToTextBox(emoji) {
        const emojiWithSpace = `${emoji} `;
        const newComment = this.state.draft.slice(0, this.state.selection.start)
            + emojiWithSpace + this.state.draft.slice(this.state.selection.end, this.state.draft.length);
        this.setState(prevState => ({
            selection: {
                start: prevState.selection.start + emojiWithSpace.length,
                end: prevState.selection.start + emojiWithSpace.length,
            },
        }));
        this.updateDraft(newComment);
    }

https://github.com/Expensify/App/blob/44c75aada4405bbff7b1c992e690b616c2c659d4/src/pages/home/report/ReportActionItemMessageEdit.js#L158 we also do the same at reportActionCompose.js

[sakluger]

I was able to reproduce this bug, passing to engineering.

[melvin-bot[bot]]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot[bot]]

Triggered auto assignment to @davidcardoza (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot[bot]]

Triggered auto assignment to @sketchydroide (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

@Puneet-here 's proposal looks good to me.

cc: @sketchydroide

:ribbon: :eyes: :ribbon: C+ reviewed

[melvin-bot[bot]]

📣 @Puneet-here You have been assigned to this job by @sketchydroide! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[sketchydroide]

not overdue...

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

• [ ] A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here:
• [ ] The PR that introduced the bug has been identified. Link to the PR:
• [ ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] Payment has been made to the issue reporter (if applicable)
• [ ] Payment has been made to the contributor that fixed the issue (if applicable)
• [ ] Payment has been made to the contributor+ that helped on the issue (if applicable)

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.22-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/12200

If no regressions arise, payment will be issued on 2022-11-09. :confetti_ball:

[sketchydroide]

@davidcardoza I think no regressions were found, so I think we are good to follow with the payment.

[davidcardoza]

Offer sent to @parasharrajat for payment

[hammad-6304]

@kavimuru I Have read the proposal on UpWork so i head to this issue. As per above discussion I can see the issue has been resolved already. Can you please confirm me is it still open & need to fix in an enhanced manner? Please let me know just looking forward to hear from your side. Thanks

[kavimuru]

@hammad-6304 Yes, it is fixed now.

[sketchydroide]

@davidcardoza anything for us to do here?

[Puneet-here]

Hi @davidcardoza, could you please send me an offer or provide the job link since it qualifies for fixing and reporting bonus.

[davidcardoza]

@Puneet-here Sent

[Puneet-here]

I have accepted the offer.

[parasharrajat]

There was no Upwork job created for this @davidcardoza. C+ is still waiting for payment on this. Please reopen it.

[davidcardoza]

@parasharrajat I sent you a payment on Upwork for the job. Can you accept?

[Puneet-here]

@davidcardoza, I only received $250. I believe the total amount should be $500, $250 for the fix and $250 for the reporting

[Puneet-here]

Bump @davidcardoza

[davidcardoza]

@Puneet-here i processed an additional $250

[Puneet-here]

I have accepted the offer, thanks

[parasharrajat]

@davidcardoza I am still awaiting payment on this. Should we reopen this issue until payment is done? It is easier to track this way.

[parasharrajat]

Bump :arrow_up:

[davidcardoza]

@parasharrajat I am showing a $250 payment was processed and accepted by you on the job - https://www.upwork.com/jobs/~01cfb61bdcd6543656

[parasharrajat]

@davidcardoza I have only accepted the offer. You still need to complete the payment and complete the contract.