App
App copied to clipboard
Expensify
[$250] BUG: Mac Safari - Sidebar animation is different reported by @mdneyazahmad
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- Goto staging https://staging.new.expensify.com/
- Click on fab
- Click request money
- Enter the amount
- Click next, and observe the animation
- Select the contact, and observe the animation
Expected Result:
Animation should be same across all sidebars
Actual Result:
Animation is not same, the sidebar does not come into view from the end of the screen like other sections
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
Version Number: 1.2.13-3 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/195650307-6f05428f-904f-4a0f-be8b-f85072bb6c2d.mp4
https://user-images.githubusercontent.com/43996225/195650316-a5bd57e3-6a5d-4dc3-887f-9eefae88e27e.mov
Expensify/Expensify Issue URL: Issue reported by: @mdneyazahmad Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665552011863769
Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @kavimuru sorry I am not clear on what the bug is here. Could you please add more detail so that I can try to reproduce. The video is not clear to me what the expected vs actual result is so if you can explain it in text so I can follow the guide to reproduce, that would be really helpful - thank you!
@zanyrenney I am attaching a new video. The sidebar animation appears from right end of the screen in profile page, preference page. But when initiating the IOU after entering the money, hitting Next no animation and next page appears from left.
https://user-images.githubusercontent.com/43996225/196058321-c3b00b94-a113-493d-b798-da554e6ced37.mp4
@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)
Current assignee @thienlnam is eligible for the External assigner, not assigning anyone new.
Going OOO next week, going to re-assign this so we can keep moving forward with proposals
Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.
Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to @Luke9389 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@JmillsExpensify, @rushatgabhane, @Luke9389 Whoops! This issue is 2 days overdue. Let's get this updated quick!
@JmillsExpensify, @rushatgabhane, @Luke9389 Whoops! This issue is 2 days overdue. Let's get this updated quick!
I'm not sure if we should fix this. We're going to refactor this entire flow very shortly, so I would be more inclined to put this bug report on hold. At the point we refactor the flow we can see if this is still an issue and then either close (and pay for reporting), or fix. Thoughts guys?
I'm fine with that. I also don't necessarily see this as a problem. It doesn't bother me at all that the animation goes two different ways.
@JmillsExpensify, @rushatgabhane, @Luke9389 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@JmillsExpensify, @rushatgabhane, @Luke9389 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.
hey @shawnborton,
What do you think about the fact that the animation goes two different directions here? Problem, not problem?
My take is that in the Settings pages, each modal page is animated. But in the IOU flow, just the content of the modal (everything below the title) is being animated. Is that the difference that we're talking about? It's a bit unclear from the comments.
@shawnborton Great point of clarification. It's basically this.
The sidebar animation appears from right end of the screen in profile page, preference page. But when initiating the IOU after entering the money, hitting Next, there no animation and next page appears from left.
This is all super subtle.
Got it. I mean yeah, ideally this would all be consistent and feel silky smooth (IOU animations feel janky on desktop at least).
100%. Where I struggle is whether we do anything now or re-evaluate once N7 hits. Maybe we just bite the bullet and tackle this now along with all the other bugs. Hmm, yeah that sounds the most logical. Agreed?
Ok cool. Upwork job is here: https://www.upwork.com/jobs/~010cf9eb9f9b6cb3b2. We're open for proposals.