App icon indicating copy to clipboard operation
App copied to clipboard

Web - Workspace - Member is shown in the created rooms after removing member from workspace

Open kavimuru opened this issue 2 years ago • 5 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing the PR #11560

Action Performed:

  1. Invite a user to a workspace
  2. Create a room with this workspace
  3. On another browser window in incognito mode sign in as that user
  4. On the window where you invited the user: Remove the same user from the workspace

Expected Result:

Member is removed from the room created in step 2

Actual Result:

Member is not removed and removed member still can send chat

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2-13-2 Reproducible in staging?: y Reproducible in production?: y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/195430891-938c342e-2ddb-42ce-a10f-caade600a878.mp4

https://user-images.githubusercontent.com/43996225/195430893-bdd01b85-b1ee-4e2f-8087-134e3a715f8f.mp4

Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

View all open jobs on GitHub

kavimuru avatar Oct 12 '22 19:10 kavimuru

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] avatar Oct 12 '22 19:10 melvin-bot[bot]

Seeing if this can still be reproduced

roryabraham avatar Oct 26 '22 10:10 roryabraham

I was blocked from testing this bug on staging by https://expensify.slack.com/archives/C01GTK53T8Q/p1666779967663819

Overall I think this is probably a legitimate bug report, but I'm not sure what the status of user-created policy rooms is. I think there are many bugs surrounding the flow, but I also think many of them are behind a beta.

@trjExpensify @JmillsExpensify is there a tracking issue for user-created policy rooms somewhere? This should probably be added to that and then handled when those are re-prioritized.

roryabraham avatar Oct 26 '22 10:10 roryabraham

I propose we add this to the tracking issue and put it on HOLD. Going to unassign for now

roryabraham avatar Oct 26 '22 10:10 roryabraham

@trjExpensify @JmillsExpensify is there a tracking issue for user-created policy rooms somewhere? This should probably be added to that and then handled when those are re-prioritized.

@MitchExpensify has been leading user-created rooms, and @Luke9389 is helping to carry it to the finish line with the missing functionality like leave/join. To answer the question though, the main issue is here I believe.

trjExpensify avatar Oct 31 '22 10:10 trjExpensify

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Nov 01 '22 18:11 melvin-bot[bot]

For what it's worth, we are rounding out that functionality now. cc @Luke9389 since I recently re-opened the issues for invite/leave.

JmillsExpensify avatar Nov 01 '22 19:11 JmillsExpensify

Yeah I think we should close this for now.

We're going to be testing this flow extensively as we build out user created rooms.

Luke9389 avatar Nov 01 '22 21:11 Luke9389

That works for me.

JmillsExpensify avatar Nov 01 '22 22:11 JmillsExpensify