App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD] mWeb- Connect Bank Account - Pressing back button at android in the middle of a step takes you back to the workspace page instead of going back to the previous step @Puneet-here

Open kbecciv opened this issue 2 years ago • 16 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com and log in
  2. Go to bank account > add info > company step
  3. Press back button of mobile

Expected Result:

ou should be navigated back to the previous step

Actual Result:

You will be navigated to the workspace page

Workaround:

Unknow

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.9.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/193102567-8d812de1-7932-4f37-9cfb-d59b118b642c.mov

Expensify/Expensify Issue URL:

Issue reported by: @Puneet-here

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663792588717789

View all open jobs on GitHub

kbecciv avatar Sep 29 '22 17:09 kbecciv

Triggered auto assignment to @joekaufmanexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

melvin-bot[bot] avatar Sep 29 '22 17:09 melvin-bot[bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] avatar Sep 30 '22 05:09 melvin-bot[bot]

I don't have an android phone, but worked with @pecanoro to reproduce this in an android device.

joekaufmanexpensify avatar Sep 30 '22 18:09 joekaufmanexpensify

Discussing ideal behavior for how this should work here.

joekaufmanexpensify avatar Sep 30 '22 18:09 joekaufmanexpensify

In the meantime, going to pass to engineering to review. Also, based on this post, whatever solution we do decide on is going to be on hold pending completion of this issue.

joekaufmanexpensify avatar Sep 30 '22 20:09 joekaufmanexpensify

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] avatar Sep 30 '22 20:09 melvin-bot[bot]

Demoting priority and adding to project: https://github.com/Expensify/App/projects/2

MariaHCD avatar Oct 03 '22 13:10 MariaHCD

Triggered auto assignment to @tjferriss (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

melvin-bot[bot] avatar Oct 18 '22 18:10 melvin-bot[bot]

I'm not able to reproduce this on web staging (v1.2.18-2) or on my iPhone app (v1.2.15-3). I am successfully taken back to the previous step. Are we sure this is still broken?

tjferriss avatar Oct 19 '22 16:10 tjferriss

Hi @tjferriss, it's still reproducible. You have to repro this on Android and you will need to press native back button.

Puneet-here avatar Oct 19 '22 17:10 Puneet-here

@MariaHCD I'm looking for your advice here based on your previous comments. If this is still reproducible should I toss it back into the engineering pool?

tjferriss avatar Oct 20 '22 22:10 tjferriss

@tjferriss I see that it is reproducible if you use the native back button on an Android device. However, I don't believe we have a solution for this yet and should continue to remain on hold as part of https://github.com/Expensify/App/issues/11768. I think there's no need for another engineer to take a look at this.

MariaHCD avatar Oct 21 '22 12:10 MariaHCD

@tjferriss Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Oct 25 '22 07:10 melvin-bot[bot]

Ok we'll hold on for now :)

tjferriss avatar Oct 25 '22 18:10 tjferriss

@tjferriss Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Oct 31 '22 07:10 melvin-bot[bot]

@tjferriss Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Oct 31 '22 08:10 melvin-bot[bot]

Still on hold

tjferriss avatar Nov 02 '22 05:11 tjferriss

Snagging this now that I'm on the tracking issue.

JmillsExpensify avatar Nov 03 '22 18:11 JmillsExpensify

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Nov 07 '22 08:11 melvin-bot[bot]

Still on hold for the tracking issue.

JmillsExpensify avatar Nov 08 '22 05:11 JmillsExpensify

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Nov 11 '22 08:11 melvin-bot[bot]

Thanks Melvin, though we're still on hold as noted above. Adding the weekly label instead.

JmillsExpensify avatar Nov 11 '22 20:11 JmillsExpensify

Still on hold.

JmillsExpensify avatar Nov 17 '22 04:11 JmillsExpensify

Still held as we go through the design process.

JmillsExpensify avatar Nov 22 '22 07:11 JmillsExpensify

On hold per the larger react navigation initiative.

JmillsExpensify avatar Nov 27 '22 06:11 JmillsExpensify

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

melvin-bot[bot] avatar Nov 27 '22 06:11 melvin-bot[bot]

Still on hold for the larger navigation re-write.

JmillsExpensify avatar Dec 05 '22 13:12 JmillsExpensify

Still on hold for navigation.

JmillsExpensify avatar Dec 12 '22 12:12 JmillsExpensify

Held on navigation revamp.

JmillsExpensify avatar Dec 19 '22 01:12 JmillsExpensify

Switching out weekly for monthly given that the navigation project is large and has no defined ETA.

JmillsExpensify avatar Dec 27 '22 20:12 JmillsExpensify