App
App copied to clipboard
[HOLD] mWeb- Connect Bank Account - Pressing back button at android in the middle of a step takes you back to the workspace page instead of going back to the previous step @Puneet-here
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- Go to staging.new.expensify.com and log in
- Go to bank account > add info > company step
- Press back button of mobile
Expected Result:
ou should be navigated back to the previous step
Actual Result:
You will be navigated to the workspace page
Workaround:
Unknow
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.2.9.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/193102567-8d812de1-7932-4f37-9cfb-d59b118b642c.mov
Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663792588717789
Triggered auto assignment to @joekaufmanexpensify (AutoAssignerTriage
), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
I don't have an android phone, but worked with @pecanoro to reproduce this in an android device.
Discussing ideal behavior for how this should work here.
In the meantime, going to pass to engineering to review. Also, based on this post, whatever solution we do decide on is going to be on hold pending completion of this issue.
Triggered auto assignment to @MariaHCD (Engineering
), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Demoting priority and adding to project: https://github.com/Expensify/App/projects/2
Triggered auto assignment to @tjferriss (AutoAssignerTriage
), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
I'm not able to reproduce this on web staging (v1.2.18-2) or on my iPhone app (v1.2.15-3). I am successfully taken back to the previous step. Are we sure this is still broken?
Hi @tjferriss, it's still reproducible. You have to repro this on Android and you will need to press native back button.
@MariaHCD I'm looking for your advice here based on your previous comments. If this is still reproducible should I toss it back into the engineering pool?
@tjferriss I see that it is reproducible if you use the native back button on an Android device. However, I don't believe we have a solution for this yet and should continue to remain on hold as part of https://github.com/Expensify/App/issues/11768. I think there's no need for another engineer to take a look at this.
@tjferriss Whoops! This issue is 2 days overdue. Let's get this updated quick!
Ok we'll hold on for now :)
@tjferriss Huh... This is 4 days overdue. Who can take care of this?
@tjferriss Huh... This is 4 days overdue. Who can take care of this?
Still on hold
Snagging this now that I'm on the tracking issue.
@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
Still on hold for the tracking issue.
@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Thanks Melvin, though we're still on hold as noted above. Adding the weekly label instead.
Still on hold.
Still held as we go through the design process.
On hold per the larger react navigation initiative.
Looks like something related to react-navigation
may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js
files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.
Still on hold for the larger navigation re-write.
Still on hold for navigation.
Held on navigation revamp.
Switching out weekly for monthly given that the navigation project is large and has no defined ETA.