App icon indicating copy to clipboard operation
App copied to clipboard

[$500] Web -Set Password - Autofill suggestion shows up for password field at set password page @thesahindia

Open kbecciv opened this issue 3 years ago • 15 comments
trafficstars

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Put new email address under log in
  3. Click continue
  4. Click Resent - Link
  5. Go to you email
  6. Copy the email into new browser and add staging before url
  7. Focus on the field

Expected Result:

Autofill suggestion shouldn't be shown

Actual Result:

Autofill shows up

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.9.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation Screenshot 2022-09-15 at 6 02 41 PM

Expensify/Expensify Issue URL:

Issue reported by: @thesahindia

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663245567576029

View all open jobs on GitHub

kbecciv avatar Sep 28 '22 20:09 kbecciv

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

melvin-bot[bot] avatar Sep 28 '22 20:09 melvin-bot[bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] avatar Sep 29 '22 17:09 melvin-bot[bot]

@Julesssss , is it possible to disable the autofill suggestions on the set password page? If so, then it makes sense to me to fix this.

mallenexpensify avatar Sep 29 '22 17:09 mallenexpensify

It should be possible, though some password managers actively ignore the prop that we can set to prevent password managers from showing.

Let's try to solve for Chrome and Safari password managers, with the understanding that 3rd party solutions are out out of scope here.

Julesssss avatar Sep 30 '22 09:09 Julesssss

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot[bot] avatar Sep 30 '22 09:09 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

melvin-bot[bot] avatar Sep 30 '22 09:09 melvin-bot[bot]

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Sep 30 '22 09:09 melvin-bot[bot]

Still looking for proposals.

mananjadhav avatar Oct 03 '22 11:10 mananjadhav

@puneetlath could we please double the bounty? Thanks!

Julesssss avatar Oct 19 '22 09:10 Julesssss

Updated to $500!

External upwork job: https://www.upwork.com/jobs/~01c664c9b077916369 Internal upowrk job: https://www.upwork.com/ab/applicants/1582732633604943872/job-details

puneetlath avatar Oct 19 '22 13:10 puneetlath

Hello!

Just add the autoComplete="off" in form element

albrimpaqarizi avatar Oct 19 '22 22:10 albrimpaqarizi

Lol, yep that sounds simple enough 😄

Would you like to work on this PR @albrimpaqarizi? Your message doesn't quite seem like a proposal so I just wanted to check before assigning this to you.

Julesssss avatar Oct 20 '22 09:10 Julesssss

@albrimpaqarizi , check https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md for more details about submitting a proposal, if interested.

mallenexpensify avatar Oct 20 '22 20:10 mallenexpensify

@mallenexpensify @Julesssss Time to double?

mananjadhav avatar Oct 31 '22 03:10 mananjadhav

I think @albrimpaqarizi's proposal sounds correct. @albrimpaqarizi would you mind reading the link here and adding a few more details on this proposal please?

Julesssss avatar Oct 31 '22 10:10 Julesssss

@johnmlee101 will this page become obsolete with #passwordless?

puneetlath avatar Nov 04 '22 15:11 puneetlath

Yess it should 😄 let's put a HOLD on this at a minimum

johnmlee101 avatar Nov 04 '22 16:11 johnmlee101

Ok I'm going to close this out then since this page is about to go away. @thesahindia I sent you a hiring offer for the reporting bonus since it is a current bug.

puneetlath avatar Nov 04 '22 17:11 puneetlath

Thanks @puneetlath but I am not sure if this is eligible since we aren't compensating unless the issue gets fixed. Also just curious what's "#passwordless", are we planning to remove passwords?

thesahindia avatar Nov 04 '22 17:11 thesahindia

Yes, we are planning to remove passwords. Which is effectively a fix for this bug, so I think it qualifies.

puneetlath avatar Nov 04 '22 17:11 puneetlath

Cool thanks for clarifying. I have accepted the offer. I think we can also close https://github.com/Expensify/App/issues/11403?

thesahindia avatar Nov 04 '22 17:11 thesahindia