[Hold]Admin Room - Infinite loading after clicking on Expensify team email - reported by @aneequeahmad

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with expensifail account
3. Create a new workspace
4. Go to settings > workspace> manage members
5. Remove the member
6. sign out
7. Login again with same user
8. Go to #admins and click on member which was removed

Expected Result:

Detail paged directed after clicking on Expensify team email

Actual Result:

Infinite loading after clicking on Expensify team email

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.6.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any expensifail accounts

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/192167874-717e73a7-5c37-46a8-ad5e-8c5c7040c3ad.MP4

Expensify/Expensify Issue URL:

Issue reported by: @aneequeahmad & Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661462019061489

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[chauchausoup]

Actually it was raised earlier in here. https://expensify.slack.com/archives/C01GTK53T8Q/p1661462019061489 Also same issue is there on various random instances. In my case if a particular chat has no timezone message shown at the bottom has shown such behaviour. Check on Slack thread to see my replication.

[cead22]

• Log in with expensifail account any expensifail accounts

@kbecciv I can't reproduce using [email protected] or [email protected]. Can you share the credentials needed to reproduce this?

[kbecciv]

@cead22

1. Log in with [email protected] /Feya86Katya
2. Go to admins room
3. Tap on email address (onboarding assistant) This issue reproduced in all environments

https://user-images.githubusercontent.com/93399543/192404698-9522eb40-54e2-4bee-aa96-88094d412665.mp4

[cead22]

I still can't reproduce, I don't even see their email in the chat, just the name

https://user-images.githubusercontent.com/165133/192878876-0a2c8911-adb4-4b32-9845-f18acf962311.MP4

[kbecciv]

@cead22 This person is fixed already, but issue is still exist for other members. [email protected]/Feya86Katya

https://user-images.githubusercontent.com/93399543/193040033-ad4a3080-cfa4-46f2-8b3d-9209adeafba5.mp4

[cead22]

Thank you, I was able to reproduce this time!

[melvin-bot[bot]]

Triggered auto assignment to @mountiny (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

[mountiny]

@kbecciv so you are saying this issue happens only for some agents?

Remove the member

The instructions are not clear to me, did you remove the agent from the workspace?

[kbecciv]

@mountiny Correct, you need to remove agent from WS.

[mountiny]

So we must be missing a details for the agent if we delete them. Then after logging out and logging back the personalDetails are not fetched again so we run into this block of code https://github.com/Expensify/App/blob/da6e3aac5b64154e1d87c261f34829e097c7b433/src/pages/DetailsPage.js#L80-L84

which renders a spinner. We need to look into why the personal details for the agent are not returned.

[mountiny]

We need to look if this query if returning it https://github.com/Expensify/Auth/blob/3a605d99af6ccebd531d0aaf957d2455e6caf485/auth/lib/Account.cpp#L1871-L1978

[mountiny]

Will continue investigating this today

[mountiny]

Havent been able to get down to this, hard to replicate locally without a guide policy

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[mountiny]

I can still reproduce, you have to remove the member from the chat and then sign out and sign back in

[mountiny]

Assigning @Justicea83 who has kindly offered to take over this one as I got some other priorities, I am gonna help you tho with investigation as much as possible. Thanks!

[Justicea83]

Still not able to reproduce this on dev. Digging in

[Justicea83]

Am able to replicate this in dev now. The spinners come on any room at all that has a message from a member who has been removed from the WS.

[mountiny]

Nice! Thanks for digging into this, I believe we will have to update (or at least look well into) this query https://github.com/Expensify/Auth/blob/3a605d99af6ccebd531d0aaf957d2455e6caf485/auth/lib/Account.cpp#L1871-L1978 which is long, I suggest posting in #engineering-chat asking about this. Should this query return such accounts?

What exactly happens in backend/db when user is removed from workspace? That will help us identify how the query needs to be updated.

[Justicea83]

Made a slack thread on this here.

[Justicea83]

Putting this issue on hold pending refactor of OpenReport

[Justicea83]

OpenReport refactorings is still a work in progress

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[Justicea83]

Not overdue, as this is fixed by the OpenReport refactorings

[mvtglobally]

Issue not reproducible during KI retests. (Third week) @Justicea83 are we ok to close this?

[Justicea83]

Yes, we're good to close this out

[melvin-bot[bot]]

Triggered auto assignment to @alexpensify because issue was reported by a contributor who needs to be compensated if this issue is fixed. @aneequeahmad reported this issue. Please review to confirm the PR fixes the bug / feature request they reported. If so, issue payment for reporting.

[melvin-bot[bot]]

Current assignee @alexpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to @luacmartins (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.