App
App copied to clipboard
Expensify
[$250] User can't download the production app from playstore
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- Go to playstore
- Download new expensify
- Open the app and login
- Check if it has a stg badge at top
Expected Result:
The app should not have the stg badge and stg features
Actual Result:
The app is stg
Workaround:
unknown
Platform:
Where is this issue occurring?
- Android
Version Number: Reproducible in staging?: need repro Reproducible in production?: need repro Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: @Puneet-here Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662562500746549?thread_ts=1660710162.573049&cid=C01GTK53T8Q
@mvtglobally Huh... This is 4 days overdue. Who can take care of this?
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mvtglobally 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
@mallenexpensify @mallenexpensify I was checking with the team on the same. There is a tricky way to download PROD build on Android with the same device as you have staging. Currently we all see STG Since all our testers are already getting BETA (STG) builds, not sure this result is accurate. Is there any chance you can ask someone in Expensify internally who DOES NOT have staging build to download PROD build?
https://user-images.githubusercontent.com/43995119/196693331-402beb99-5498-4497-b2a6-ca15d1eaeb11.mp4
Asking internally https://expensify.slack.com/archives/C01SKUP7QR0/p1666291488048139
Gonna close cuz @alex-mechler was able to help test and it looks like its not repro
@mallenexpensify, in the screenshot I can see the stg badge at the login page.
ah shit... you're right @Puneet-here , great 👀 .
Reopening and assigning an engineer to take a look
Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Oh, I think this is a dupe of https://github.com/Expensify/Expensify/issues/237206 and it is probably internal
Ummm, isn't play store downloading the staging app because you are in the beta???
Ummm, isn't play store downloading the staging app because you are in the beta???
No, I don't think this is the case because external contributors aren't in the beta and I have tried some different accounts that I've never used at expensify but I still couldn't download the production app.
Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)
Triggered auto assignment to @srikarparsi (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Hi I saw the job on Upwork and did some digging, checked the code and everything seems to be good, unless someone pushed a staging build to the production?
Coz the environment variables are the only things that differentiates things in the process, so maybe the build pushed to the production (public) is a staging environment build?
If not, can I more context on it? I mean like access to things like developer console, from which I can find answers and most probably solution?
did some digging, checked the code and everything seems to be good, unless someone pushed a staging build to the production?
I also feel the same. @srikarparsi, can you please look into it?
I am not too sure but seems to me that it could be a caching issue. The build that gets downloaded and then that build does not match with version in package.json in the build. And then we see a badge.
I hypothesize this as I see version shown in screenshot is different from what should have been in playstore at that time ( by looking at the release in github). We had a newer build versions deployed to PROD on Oct 17 i.e 1.2.17-4 where as @mallenexpensify 's screenshot on Oct 21 says build version is 1.2.16-5. See the below.
I could be totally wrong but I had recently seen this code that puts tha badge. And i think because of this mismatch in versions we see that badge
asked internally @thesahindia, will get back to you on if we pushed a stg build to prod
I don't believe there was an accidental deploy, as our internal releases line up with the PlayStore builds. Instead, it seems like a regression in our versioning logic as was suggested above.
Staging version: 1.2.18
Prod version: 1.2.19-1
that means there would have to be a PR recently which would break this logic, that could help narrowing this down
Adding the deployBlockerLabel to prevent further deploys until we can confirm the cause. I know it's useless given this exists on prod, but it'll hopefully speed up the release of the eventual fix 🤞
that means there would have to be a PR recently which would break this logic, that could help narrowing this down
Just want to inform that I had reported this on Aug 17, if it helps.
This is the deploy checklist for the current prod build, which occurred on August 17th. There were two releases in quick succession on Aug 16th too (1 + 2).
Nothing stands out as a potential cause 😕
Removing deploy blocker label since its not really a blocker. But keeping the hourly tag since it sounds urgent to address. I think we can also create a fire-room to discuss this.
