[HOLD for payment 2022-10-31] [$250] Payment methods have wrong height - reported by @rushatgabhane

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login
2. Go to Settings -> Payments

Expected Result:

Payment methods have a height of 64px

Actual Result:

Payment methods have a height of 64.5px

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.1.96-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL: Issue reported by: @rushatgabhane Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661196724356509

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Puneet-here]

Proposal

We need to pass styles.lh16 here

https://github.com/Expensify/App/blob/85172f72f1abbf1976e6abd3c08f5f74c04ae1b6/src/components/MenuItem.js#L55

[flaviadefaria]

Adding the engineering label but doesn't seem like a priority.

[melvin-bot[bot]]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot[bot]]

@MonilBhavsar Eep! 4 days overdue now. Issues have feelings too...

[MonilBhavsar]

Not priority, coming back

[MonilBhavsar]

Not priority, coming back

[Puneet-here]

@MonilBhavsar, this can be fixed by only adding a style as proposed here.

[melvin-bot[bot]]

Triggered auto assignment to @flaviadefaria (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot[bot]]

Current assignee @MonilBhavsar is eligible for the External assigner, not assigning anyone new.

[flaviadefaria]

Just noting that there's also a solution discussed in the GH's Slack thread.

[flaviadefaria]

Just noting that I'm waiting on my Upwork access to post this.

[sobitneupane]

Adding styles.lh16 will be enough to make Payment methods height 64. But I am not sure what is the expected output here. Want to have some feedback from Design team before moving forward.

cc: @MonilBhavsar, @shawnborton

[shawnborton]

I think that should do it, yeah. We will just want to be sure to test this with various platform zooms, etc.

[sobitneupane]

Thanks @shawnborton.

@MonilBhavsar Proposal from @Puneet-here looks good to me.

🎀👀🎀 C+ reviewed

[flaviadefaria]

Internal job post - https://www.upwork.com/ab/applicants/1579798560037728256/job-details External post - https://www.upwork.com/jobs/~0102289ba6d99dee28

[flaviadefaria]

@MonilBhavsar I think we're just waiting on you now to move forward with the proposal.

[MonilBhavsar]

Thanks for ping! Yes, looks good to me too 👍

[melvin-bot[bot]]

📣 @Puneet-here You have been assigned to this job by @MonilBhavsar! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[MonilBhavsar]

@shawnborton a suggestion: How about having preferred CSS stylings/dimensions in a doc and include that in our PR Review checklist?

[shawnborton]

Yeah, I think ideally this row component would be documented in some kind of style guide. Not sure how that works with a PR checklist but I do think that we should require a design review on all PRs - I will propose that soon!

[MonilBhavsar]

I mean If a new UI component is added, verifying its dimensions are as per our standard (Not sure, but may be a multiple of 8 always)

[flaviadefaria]

I'll come back to this in the next days.

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.18-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/11838

If no regressions arise, payment will be issued on 2022-10-31. :confetti_ball:

[MonilBhavsar]

@flaviadefaria I think we're good to issue payment to everyone

[sobitneupane]

@flaviadefaria Waiting for payment.

[flaviadefaria]

Sorry for the delay here. I'll process the payment now.

[flaviadefaria]

@sobitneupane @Puneet-here you haven't applied so I invited you two to the job please accept and comment here when you have done so. Thanks!

[sobitneupane]

@flaviadefaria Accepted.