App
App copied to clipboard
Expensify
[$500] iOS - Conversation - If the last message is deleted, the previous one becomes partially hidden
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- Open the App and login with any account
- Go to any conversation
- Send 2 or more messages
- Delete the latest message
Expected Result:
The previous message should not be hidden
Actual Result:
The previous message becomes partially hidden
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.96.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/188025493-15d3a984-ccec-4e20-8706-7deae4c33626.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.
@JmillsExpensify let me know when you post the job. Description is clear and it is reproducible
Upwork job is here: https://www.upwork.com/jobs/~012e25f97da880eedd. We're open for proposals.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)
Current assignee @ctkochan22 is eligible for the Exported assigner, not assigning anyone new.
@kbecciv is this reproducible now?
I am unable to reproduce this issue
Proposal:
Changing "contentContainerStyle" of InvertedFlatList in ReportActionsList.js as follows fixes the issue.
The issue arrived because the padding between InvertedFlatList and TextInputContainer was reduced to 0 (as visible in above image) to accommodate Recipient's Local Time. Which wasn't the correct change as the padding in absence of Recipient's Local Time is 16, https://github.com/Expensify/App/blob/a24de554bd2e70575f4389942d6132d7ca9ea082/src/styles/styles.js#L1268-L1272 so counting marginTop = 5 of Recipient's Local Time's View Container, https://github.com/Expensify/App/blob/a24de554bd2e70575f4389942d6132d7ca9ea082/src/pages/home/report/ParticipantLocalTime.js#L63 https://github.com/Expensify/App/blob/a24de554bd2e70575f4389942d6132d7ca9ea082/src/styles/styles.js#L643-L647 the correct padding should be 11 and pt3 is the closest to that.
Before: https://user-images.githubusercontent.com/93445984/191662026-7189564b-380d-462e-b55e-bc6661aabc7b.mp4
After: https://user-images.githubusercontent.com/93445984/191663285-2d90fb36-4129-4bcb-97e2-ab56956aadc6.mp4
Hey @Santhosh-Sellavel you can reproduce the issue by following the steps below:
- Send multiple messages.
- Keep the textinput focused, so that keyboard stays open.
- Delete the last message.
@Santhosh-Sellavel Issue is still reproducible.
https://user-images.githubusercontent.com/93399543/191787415-178d6a23-1583-412f-be6e-31300d04a8a4.MP4
@Santhosh-Sellavel Issue is still reproducible.
RPReplay_Final1663859877.MP4
@kbecciv this looks likely from an simulator is this reproducible on any real device
⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
@JmillsExpensify, @ctkochan22, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Hi, @JmillsExpensify @ctkochan22 @Santhosh-Sellavel @kbecciv can you take a look at my proposal?
@advaitasol9 is this issue reproducible for you on staging/ latest main.
Hey @Santhosh-Sellavel you can reproduce the issue by following the steps below:
- Send multiple messages.
- Keep the textinput focused, so that keyboard stays open.
- Delete the last message.
Yes @Santhosh-Sellavel, below is a video from few days ago while I was testing on main branch. In my testing I found the issue is only happening when we delete the message while the keyboard is open.
https://user-images.githubusercontent.com/93445984/192520952-a0c19e92-d477-4de2-8cb5-38bb3c5c1625.mp4
Yes @Santhosh-Sellavel, below is a video from few days ago while I was testing on main branch. In my testing I found the issue is only happening when we delete the message while the keyboard is open.
@advaitasol9 Can you check now on staging build or latest main
@JmillsExpensify @advaitasol9 's proposal looks good.
@ctkochan22 thanks for the quick review, if possible can you wait one more day? I'm investigating this & other related issues.
Thanks!