App icon indicating copy to clipboard operation
App copied to clipboard

[$8000] Safari mWeb - Keyboard won't open for some inputs (New Chat, Change Password, New Room)

Open kbecciv opened this issue 2 years ago • 209 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR https://github.com/Expensify/App/pull/10194

Action Performed:

case 1

  1. Access staging.new.expensify.com
  2. Sign into a valid user
  3. Click on the "Global action" button (Big green plus button in LHN)
  4. Click New Chat

case 2

  1. Go to https://staging.new.expensify.com/
  2. Login with expensifail account
  3. Create a Workspace
  4. Tap "+"
  5. Tap "New Room"

case 3

  1. Go to https://staging.new.expensify.com/
  2. Sign into a valid user
  3. Go to settings > security > change password

case 4

  1. Go to https://staging.new.expensify.com/
  2. Sign into a valid user
  3. Go to some DM
  4. Open the in app emoji picker
  5. Select some emoji

Expected Result:

Keyboard is open and cursor focused when entering the new screen

Actual Result:

Keyboard won't open

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Safari Mobile Web

Version Number: 1.1.88.13

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Case 1

https://user-images.githubusercontent.com/93399543/185005745-73a26290-2721-4b14-b3bd-ba0553a2a0a8.mp4

Case 2

https://user-images.githubusercontent.com/93399543/195383970-9354b2d0-cffc-4b1d-b5d2-2804c2462a5e.mp4

Case 3

https://user-images.githubusercontent.com/43995119/190952432-d072befe-c01d-404e-92fd-b6c71ff230c9.mov

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Tea

Slack conversation:

View all open jobs on GitHub

kbecciv avatar Aug 17 '22 00:08 kbecciv

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] avatar Aug 17 '22 00:08 melvin-bot[bot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot[bot] avatar Aug 17 '22 15:08 melvin-bot[bot]

job post: https://www.upwork.com/jobs/~01f21a08ef50dd0283

NicMendonca avatar Aug 18 '22 11:08 NicMendonca

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

melvin-bot[bot] avatar Aug 18 '22 12:08 melvin-bot[bot]

Triggered auto assignment to @sketchydroide (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] avatar Aug 18 '22 12:08 melvin-bot[bot]

The text is not having top "priority" or the list is getting auto focus. You should give change the layout, something zIndex or ... set focus programmatically.

busyboxww avatar Aug 18 '22 13:08 busyboxww

Interesting.. it tested well when I added screenshots for PR https://github.com/Expensify/App/pull/10194

rushatgabhane avatar Aug 22 '22 17:08 rushatgabhane

I can't repro this bug on mWeb iOS, and mWeb Android. v 1.1.89-1

mWeb iOS Safari

https://user-images.githubusercontent.com/29673073/186508861-e30fecf7-d584-4118-9b00-083c5e661694.mov

mWeb Android Chrome

https://user-images.githubusercontent.com/29673073/186509173-15482710-c717-44f9-9e3e-46d97ee19b23.mp4

rushatgabhane avatar Aug 24 '22 19:08 rushatgabhane

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] avatar Aug 24 '22 19:08 melvin-bot[bot]

@rushatgabhane are you recommending that I close this?

NicMendonca avatar Aug 26 '22 17:08 NicMendonca

@NicMendonca not exactly. Let's close this bug if @kbecciv cannot repro it either

rushatgabhane avatar Aug 26 '22 17:08 rushatgabhane

@rushatgabhane Issue is reproduced with latest build 1.1.94.4

https://user-images.githubusercontent.com/93399543/187564523-ea61b4d2-b8ff-4d5f-a70f-2d42605dc211.MP4

kbecciv avatar Aug 31 '22 00:08 kbecciv

Still reproducible ☝️

NicMendonca avatar Sep 05 '22 09:09 NicMendonca

@parasharrajat what should we do? (i still can't reproduce it)

rushatgabhane avatar Sep 05 '22 12:09 rushatgabhane

I will check it later.

parasharrajat avatar Sep 05 '22 14:09 parasharrajat

I am able to reproduce this. iPhone 13 (iOS 15). I feel like maybe this is happening due to the banner. The banner is not visible when a new chat page is opened and there is empty space below the modal. This empty seems equal to the banner height.

image

parasharrajat avatar Sep 06 '22 19:09 parasharrajat

@parasharrajat did you have time to look into this?

sketchydroide avatar Sep 15 '22 14:09 sketchydroide

I already did https://github.com/Expensify/App/issues/10414#issuecomment-1238555503. Are you talking about something else?

I am open to proposals.

parasharrajat avatar Sep 15 '22 18:09 parasharrajat

no sorry, it's weird, but I' sure I did not have you comment with the screenshot when I wrote my comment, maybe GH did not refresh it, weird.

sketchydroide avatar Sep 19 '22 13:09 sketchydroide

price doubled - https://www.upwork.com/jobs/~01f21a08ef50dd0283

NicMendonca avatar Sep 23 '22 13:09 NicMendonca

doubled: https://www.upwork.com/jobs/~01f21a08ef50dd0283

NicMendonca avatar Oct 03 '22 12:10 NicMendonca

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] avatar Oct 04 '22 02:10 melvin-bot[bot]

doubled: https://www.upwork.com/jobs/~01f21a08ef50dd0283

NicMendonca avatar Oct 11 '22 20:10 NicMendonca

Is the issue I'm facing the same as this one? On desktop, staging, v1.2.15-2

  • Follow repro steps in OP
  • After clicking a new chat, cursor isn't focused on compose box, unable to start typing immediately, have to click compose box to do so.

Same for when I click on a chat in LHN, cursor doesn't show in compose box

mallenexpensify avatar Oct 14 '22 17:10 mallenexpensify

That sounds like a new issue and I saw a bug report for it somewhere. This issue is concerned on the search box on the new chat and new group page.

parasharrajat avatar Oct 14 '22 17:10 parasharrajat

Thanks @parasharrajat https://expensify.slack.com/archives/C01GTK53T8Q/p1665792005925189

mallenexpensify avatar Oct 15 '22 00:10 mallenexpensify

doubled price: https://www.upwork.com/jobs/~01f21a08ef50dd0283

NicMendonca avatar Oct 20 '22 12:10 NicMendonca

@NicMendonca Should we merge all of the mentioned issues into this https://github.com/Expensify/App/pull/11794#issuecomment-1280776271. cc: @sketchydroide

parasharrajat avatar Oct 20 '22 13:10 parasharrajat

@parasharrajat maybe open up a discussion in slack?

NicMendonca avatar Oct 24 '22 15:10 NicMendonca

@sketchydroide What do you think of https://github.com/Expensify/App/issues/10414#issuecomment-1285514867?

parasharrajat avatar Oct 27 '22 16:10 parasharrajat