waggle-dance icon indicating copy to clipboard operation
waggle-dance copied to clipboard

Improve validation of ACCESS_CONTROL_TYPE settings for the FederatedMetastore

Open patduin opened this issue 5 years ago • 3 comments

From the docs:

Primary metastores can configure access-control-type to have any of the described access-control-types whereas federated metastores may only be configured to READ_ONLY and READ_AND_WRITE_ON_DATABASE_WHITELIST.

The validation for these settings should be done on the configuration object com.hotels.bdp.waggledance.api.model.FederatedMetaStore. Instead currently the settings are validated in the com.hotels.bdp.waggledance.server.security.AccessControlHandlerFactory which isn't launched until a request made. Ideally WD shouldn't start if the configuration is wrong.

Acceptance Criteria:

  • WD doesn't start when the FederatedMetastore is configured with access_control_values: READ_AND_WRITE_AND_CREATE or READ_AND_WRITE_AND_CREATE_ON_DATABASE_WHITELIST.

patduin avatar Apr 29 '19 10:04 patduin

We should take #153 and #154 into account while working on this. It might be useful to just fix this now but bear in mind it might no longer be needed (or will need to be implemented differently) if/when those tickets are worked on.

massdosage avatar Apr 29 '19 10:04 massdosage

@patduin is this worth keeping open?

massdosage avatar Feb 13 '20 12:02 massdosage

Would be nice to fix, but yeah time...

patduin avatar Feb 13 '20 12:02 patduin