kube-graffiti icon indicating copy to clipboard operation
kube-graffiti copied to clipboard

Failed to decode AdmissionReview: Unkown field requestKind

Open arodriguezdlc opened this issue 5 years ago • 3 comments

I'm having errors like this:

1:45PM ERR failed to decode AdmissionReview request error="json: unknown field \"requestKind\"" component=webhook host=kube-graffiti:443 method=POST remote=10.255.255.5:45462 ua=kube-apiserver-admission url=/graffiti/do-not-inject-istio-sidecar-to-kubernetes-jobs

I have seen that kube-graffiti has k8s 1.14 libraries, but not 1.15, which is my k8s cluster version. So I think, kube-graffiti is incompatible with k8s. 1.15+

I'm now updating kube-graffiti to k8s 1.15, I hope it can solve this issue.

arodriguezdlc avatar Dec 23 '19 13:12 arodriguezdlc

@davidmccormick We are maintaining a fork that supports both k8s 1.15 and k8s 1.16. Are you open to contributions to this repo. Otherwise, does marking this repo as "unmaintained" in the README, with a link to our fork in the README, looks like a good idea to you? Thx.

palmerabollo avatar Jun 18 '20 11:06 palmerabollo

Hi Guido

I’d gladly accept any pull requests you want to make?

Regards

Dave

On 18 Jun 2020, at 12:25, Guido García [email protected] wrote:

 @davidmccormick We are maintaining a fork that supports both k8s 1.15 and k8s 1.16. Are you open to contributions to this repo. Otherwise, does marking this repo as "unmaintained" in the README, with a link to our fork in the README, looks like a good idea to you? Thx.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

davidmccormick avatar Jun 18 '20 20:06 davidmccormick

Thanks, @davidmccormick.

  • this one https://github.com/HotelsDotCom/kube-graffiti/pull/10 adds supports for k8s 1.15 (and closes this issue).
  • this one https://github.com/Telefonica/kube-graffiti/pull/1 adds supports for k8s 1.16. We can send a PR against this repo to avoid our fork.

In our fork we're starting to tag and release a docker image associated to each kubernetes version, to have some kind of compatibility matrix.

palmerabollo avatar Jun 19 '20 06:06 palmerabollo