graphql-kotlin icon indicating copy to clipboard operation
graphql-kotlin copied to clipboard

Version 8.6.0 and onwards was based on 8.2.1

Open erikogenvik opened this issue 8 months ago • 5 comments

When version 8.6.0 was created it was (probably by mistake) based on version 8.2.1 instead of 8.5.0. The result is that all versions on the 8.x.x branch from 8.6.0 and onwards don't contain the changes made to 8.4.0 and 8.5.0 (such as bumps to Kotlin and Ktor amongst others).

Conversely the "master" branch don't contain any of the fixes in 8.x.x.

There are a couple of solutions, but I leave it to the maintainers to decide on the best course.

One option is to merge all changes up to 8.5.0 into the 8.x.x. branch. Another one is to cherry pick.

Image

erikogenvik avatar Jun 30 '25 11:06 erikogenvik

Related issue: https://github.com/ExpediaGroup/graphql-kotlin/issues/2113

anton-subbotin avatar Jul 03 '25 12:07 anton-subbotin

Related issue: https://github.com/ExpediaGroup/graphql-kotlin/issues/2121

jurmous avatar Aug 08 '25 14:08 jurmous

@samuelAndalon, sorry for mentioning (maybe this issue got unnoticed), but can this be addressed? Its quite critical.

pdambrauskas avatar Oct 01 '25 07:10 pdambrauskas

Thats my bad, i made a mistake when releasing graphql-kotlin 8.3.0 -- that should've been a breaking change (ktor 3, kotlin 2), i was supposed to do a mayor release. To avoid doing bunch of reverts, I decided to start with alpha releases for v9

this is the mapping i had to do in github 8.3.0 -> 9.0.0-alpha.1 8.4.0 -> 9.0.0-alpha.2 8.5.0 -> 9.0.0-alpha.3

8.6.0 is now the latest release from 8.x.x branch and 9.0.0-alpha.4 is the latest release from master/main branch

apologizes for the miss understanding and the inconveniences

samuelAndalon avatar Oct 01 '25 14:10 samuelAndalon

@samuelAndalon I missed a note in release notes that this was done in this way. It seems there was a note in 8.6 linking to a release/tag which was removed.

Alpha releases always look scary to me to use in production and is filtered out by our refreshVersions script. I hope version 9 will then be released soon. I will try this alpha out on our backend in the mean time and switch finally away from 8.5.0. (We were already on Ktor 3 and kotlin 2.0 for a while thanks to 8.5.0)

Thanks for the update!

jurmous avatar Oct 01 '25 15:10 jurmous