graphql-kotlin icon indicating copy to clipboard operation
graphql-kotlin copied to clipboard
verified publisher icon ExpediaGroup

Upgrade to ktor version 3

Open ronjunevaldoz opened this issue 1 year ago • 1 comments

:pencil: Description

Upgrade ktor to version 3.x.x

:link: Related Issues

https://github.com/ExpediaGroup/graphql-kotlin/issues/2037

ronjunevaldoz avatar Oct 05 '24 11:10 ronjunevaldoz

found some error that requires Kotlin version to be at-least 2.0.0-RC1.

Since there was an existing TODO, I let someone upgrade it first then. I'll bump to ktor stable versions instead (v3.0.0)

TODO kotlin 1.9 upgrade: fix GraphQLTestUtils and GenerateKotlinxClientIT

Your current Kotlin version is 1.9.24, while kotlinx.serialization core runtime 1.7.2 requires at least Kotlin 2.0.0-RC1. Please update your Kotlin compiler and IDE plugin.

ronjunevaldoz avatar Oct 17 '24 11:10 ronjunevaldoz

@ronjunevaldoz Kotlin is now bumped to version 2 so this could be picked up again

daniel-humla avatar Nov 08 '24 09:11 daniel-humla

@ronjunevaldoz Kotlin is now bumped to version 2 so this could be picked up again

checking on it

ronjunevaldoz avatar Nov 14 '24 15:11 ronjunevaldoz

closing in favor of the other ktor update PR

samuelAndalon avatar Nov 20 '24 19:11 samuelAndalon