skyblock-2.0 icon indicating copy to clipboard operation
skyblock-2.0 copied to clipboard

Potential security issue

Open ghost opened this issue 1 year ago • 0 comments

Checking event.getView().getTitle() to see whether your custom inventory is being used is unsafe, as renaming a chest in an anvil allows users to set their own inventory titles. The correct way to check if your custom inventory is involved with an event is by using custom holders, see here: https://docs.papermc.io/paper/dev/custom-inventory-holder

https://github.com/Exortions/skyblock-2.0/blob/a73401274ae5638aacb203b9e64d400c46c25949/src/main/java/com/skyblock/skyblock/features/enchantment/AnvilGUI.java#L65

ghost avatar Jan 26 '24 21:01 ghost