Fix BmffImage::writeMetadata() error id/message
Codecov Report
Merging #2364 (f089398) into main (640b0fb) will increase coverage by
0.62%. The diff coverage is0.00%.
@@ Coverage Diff @@
## main #2364 +/- ##
==========================================
+ Coverage 63.51% 64.14% +0.62%
==========================================
Files 119 119
Lines 20634 21071 +437
Branches 10245 10394 +149
==========================================
+ Hits 13106 13515 +409
- Misses 5399 5400 +1
- Partials 2129 2156 +27
| Impacted Files | Coverage Δ | |
|---|---|---|
| include/exiv2/bmffimage.hpp | 100.00% <ø> (ø) |
|
| src/bmffimage.cpp | 75.75% <0.00%> (-1.07%) |
:arrow_down: |
| src/tiffimage_int.cpp | 79.58% <0.00%> (-0.25%) |
:arrow_down: |
| src/types.cpp | 94.44% <0.00%> (-0.04%) |
:arrow_down: |
| src/easyaccess.cpp | 93.10% <0.00%> (ø) |
|
| src/makernote_int.cpp | 65.39% <0.00%> (+0.76%) |
:arrow_up: |
| src/quicktimevideo.cpp | 58.15% <0.00%> (+1.18%) |
:arrow_up: |
| src/tags_int.hpp | 91.17% <0.00%> (+2.80%) |
:arrow_up: |
| src/minoltamn_int.cpp | 60.98% <0.00%> (+5.92%) |
:arrow_up: |
| src/sonymn_int.cpp | 77.36% <0.00%> (+19.15%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@piponazo
I have also added exceptions when setting ExifData, IptcData and XmpData as we don't support this in BMFF files. Do I need to add tests to demonstrate this or are you satisfied that the PR is simple enough to approve?
Please backport to 0.27-maintenance as well.
Gr8! Thank You so much.