exiv2 icon indicating copy to clipboard operation
exiv2 copied to clipboard

Better integration of PVS-Studio with github actions

Open piponazo opened this issue 3 years ago • 2 comments

Is your feature request related to a problem?

We are adding a CI job to perform static analysis checks to our project via PVS-Studio: see #2061. At the moment we are just running this check, generating a HTML report and storing it as an artifact that can be downloaded an examined.

It would be great to spend some more time on the integration of the tool with Github actions in order to have:

  • Reports that can be seen without needing to generate & download artifacts.
  • Block PRs in case new issues are detected.
  • Only check files that has changed in a PR.
  • Show number of existing issues / fixed issues in a PR.

piponazo avatar Feb 05 '22 10:02 piponazo

@piponazo Head's up, Luis. There's "secrets advisory" concerning PVS_KEY and PVS_USERNAME being exposed somewhere.

https://github.com/Exiv2/exiv2/settings/secrets/actions

clanmills avatar Feb 24 '22 09:02 clanmills

Hi Robin, I replied to you in the team chat. Let's discuss this privately.

piponazo avatar Feb 24 '22 19:02 piponazo