EXILED icon indicating copy to clipboard operation
EXILED copied to clipboard

Add debug view, embed pdb

Open warquys opened this issue 1 year ago • 6 comments

When I use debug mode, there is very quickly too much information that can be compressed onto the summary when I inspect an item. I reduced the important properties to 4 and named them to make things clearer. I also avoided invoking the sub ToString by only displaying the most important prop. In the case of Rooms.

the reasons why the pdb is added directly to the assembly, this will make distribution easier, I have seen too many logs which do not include the line causing the error in Exiled. This edition. This edition will make it easier to read errors for new devs. and will facilitate debugging without having to recompile exiled.

Changes made to Attachment Identifier make code easier to read and faster. I'll let you judge it for yourself.

warquys avatar Dec 19 '23 12:12 warquys

Also i feel like this should be kept inside .ToString() but i will let Nao handle your PR

louis1706 avatar Dec 20 '23 08:12 louis1706

Also, you may consider to use properties instead of Get methods.

NaoUnderscore avatar Dec 20 '23 20:12 NaoUnderscore

I can't get a point of adding DebuggerDisplay. Debugging plugins for unity projects is not available in IDEs

VALERA771 avatar Dec 20 '23 22:12 VALERA771

All the GetDebugDisplay are change to prop and rename to DebugDiplay.

warquys avatar Dec 21 '23 06:12 warquys

I can't get a point of adding DebuggerDisplay. Debugging plugins for unity projects is not available in IDEs

I use Visual Studio and is valid for unity debugging.

image

Yes obviously client modifications are ~~necessary~~ recomanded to avoid timeout. But, it is possible to automate everything with dummy and avoid a client connection or to launch another thread to restart the timeout counter of the client during debugging (server side).

warquys avatar Dec 21 '23 06:12 warquys

@NaoUnderscore Consider looking into merging or closing this PR.

iamalexrouse avatar Jun 30 '24 02:06 iamalexrouse

@warquys The main concern I have is that while this is good for development environments where most plugins will be developed, and debugged, but it can become detrimental to space and performance in high-performance applications like a game server.

If you can make a configurable option for this, that would make this even better for different environments.

iamalexrouse avatar Jul 17 '24 06:07 iamalexrouse

@NaoUnderscore Consider closing this PR for being stale.

iamalexrouse avatar Jul 24 '24 02:07 iamalexrouse