EXILED icon indicating copy to clipboard operation
EXILED copied to clipboard

Add ChangedAttachmentsEvent

Open louis1706 opened this issue 1 year ago • 4 comments

louis1706 avatar Dec 04 '23 08:12 louis1706

Waiting for successful CI.

iamalexrouse avatar May 29 '24 07:05 iamalexrouse

@ALEXWARELLC CI is successful

Misfiy avatar May 30 '24 05:05 Misfiy

Tested by @ALEXWARELLC : Not working

Misfiy avatar Jun 25 '24 07:06 Misfiy

Hello!

After performing some more tests, here's a bit more detail into what's happening.

Item.ChangingAmmo

This works as expected. Below is image proof of Item.ChangingAmmo working.

image

Item.ChangedAttachments

This DOES NOT work as expected. The event is effectively, never triggered, and needs to be fixed.

Thanks,

  • Alex

iamalexrouse avatar Jul 02 '24 03:07 iamalexrouse

Fixed the patches Fixed editing the attachments not doing anything in ChangingAttachmentsEventArgs Renamed "current" attachments to "old" attachments to be clearer

IkaOverride avatar Jul 03 '24 00:07 IkaOverride

Fixed the patches

Fixed editing the attachments not doing anything in ChangingAttachmentsEventArgs

Renamed "current" attachments to "old" attachments to be clearer

Should I test once more?

iamalexrouse avatar Jul 03 '24 04:07 iamalexrouse

I don't think, I tested a little bit and it was working but if you want to just in case you can

IkaOverride avatar Jul 03 '24 10:07 IkaOverride