Isca icon indicating copy to clipboard operation
Isca copied to clipboard

Radiation changes

Open ntlewis opened this issue 6 years ago • 6 comments

A few changes are in here:

  1. Multiply insolation in rrtm_radiation and two_stream_gray_rad by rrsun so that non-zero eccentricity has an effect.

  2. Add deallocation for h2o input file interpolation to rrtm_radiation (was missing before).

  3. Add option to prescribe h2o to two_stream_gray_rad from input file using the interpolator.

  4. Add Nakajima 1992 definition of longwave optical depths to two_stream_gray_rad as additional gray radiation scheme option. Ref: https://journals.ametsoc.org/doi/abs/10.1175/1520-0469(1992)049%3C2256:ASOTGE%3E2.0.CO;2.

All additions have been tested.

ntlewis avatar Jun 29 '18 18:06 ntlewis

I didn't intend to pass across the `Add T21 spectral resolution to experiment.py' commit, as it has a missing curly brace after the resolution definition. How do I remedy this?

ntlewis avatar Jun 29 '18 18:06 ntlewis

You can commit a fix to the same branch and the PR will pick it up

On 29 Jun 2018, at 19:20, Neil Lewis [email protected] wrote:

I didn't intend to pass across the `Add T21 spectral resolution to experiment.py' commit, as it has a missing curly brace after the resolution definition. How do I remedy this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jamesp avatar Jun 30 '18 18:06 jamesp

Issue fixed. I left in the T21 resolution definition, but added the missing brace, as I figured it could be useful to someone at some point.

ntlewis avatar Jul 03 '18 14:07 ntlewis

Great. Yes - definitely a useful addition, thanks for doing that

jamesp avatar Jul 03 '18 15:07 jamesp

@jamesp My apologies for some of the garbage thats ended up in this commit! I'll work through cleaning it up in the next week or two.

ntlewis avatar Sep 20 '18 09:09 ntlewis

@jamesp I think I've tidied this up now so should be ready to merge :smile:

ntlewis avatar Feb 27 '19 10:02 ntlewis