Isca icon indicating copy to clipboard operation
Isca copied to clipboard

RAS output problems

Open sit23 opened this issue 3 years ago • 1 comments

The problem

Recently it was reported that there were issues with the diagnostic outputs from the RAS modules (the scheme itself seems to run fine). The problems were that the output appeared different depending on the number of cores used, and it was clearly non-hemispherically symmetric, even when the setup was symmetric in other senses.

The fix Old 2006 FMS version requires is, js, and sometimes ks to be supplied to send_data. More recent FMS, upon which Isca is based, seems to not want these variables to be passed, and runs better without them. The old syntax was still being used in RAS, so problems were reported with the outputs. This commit corrects this problem, and the outputs are much improved.

sit23 avatar Jun 16 '21 11:06 sit23

Trip tests are passing, so I think this is safe to merge in.

Results for all of the test cases ran comparing 75880af and 2b603fa are as follows...
axisymmetric : pass
bucket_model : pass
frierson : pass
giant_planet : pass
held_suarez : pass
MiMA : pass
realistic_continents_fixed_sst : pass
realistic_continents_variable_qflux : pass
socrates_aquaplanet : pass
top_down_test : pass
variable_co2_grey : pass
variable_co2_rrtm : pass
ape_aquaplanet : pass

sit23 avatar Jun 16 '21 14:06 sit23