protocolize icon indicating copy to clipboard operation
protocolize copied to clipboard

Performance issues

Open dnbghnksrghb opened this issue 9 months ago • 4 comments

Place blocks or right click items caused proxy lag and using huge of CPU and no error

To reproduce just need about 15 ~ 30 cps to right click / place block

Proxy: Velocity/Flamecord (both lastest) , only install protocolize(1060) and protocolize-legacy(949)

Server: Paper 1.8.8 Client: 1.8.9

dnbghnksrghb avatar May 09 '24 04:05 dnbghnksrghb

Same issue we meet. Players quickly take out or put in items from / to chest can cause a lag, client will see a high ping at that time.

After uninstall protocolize, the bug disappeared. Then I found this issue post, the same cpu usage found out too. image

Using BungeeCord latest build with protocolize 2.3.3:1069.

MagmaBlock avatar May 22 '24 06:05 MagmaBlock

Hello, sorry, with some version this stopped happening or to this day you still have this problem. The same thing really happens to me.

Duplimon avatar Jun 09 '24 06:06 Duplimon

Hello, I have identified the cause of this problem, the problem is caused by the use of stream in this code line https://github.com/Exceptionflug/protocolize/blob/f1fa885bfce002b196795d854095dedeea0f2fbd/protocolize-api/src/main/java/dev/simplix/protocolize/api/SimpleMappingProvider.java#L31 the solution is to make a rollback as it was in the following commit https://github.com/Exceptionflug/protocolize/commit/96182351699644dd19946d702e82639927259425

MattyHD0 avatar Jun 09 '24 07:06 MattyHD0

Should be fixed in the latest protocolize build

Exceptionflug avatar Jun 27 '24 17:06 Exceptionflug