protocolize icon indicating copy to clipboard operation
protocolize copied to clipboard

Issue with item stacks

Open LaserSlime opened this issue 2 years ago • 6 comments

Describe the bug The display name and lore of item stacks is always italic. Even when putting a §r at the beginning of the string. The only way to prevent this is to use components, which is very inconvenient. Also the methods to modify the lore don't return the item stack like all the other ItemStack methods.

To Reproduce Steps to reproduce the behavior:

  1. Create an itemstack.
  2. Add a lore or display name starting with "§r" to it.
  3. Put it in a gui and show it to the player.
  4. See how the text is still italic despite being reset.

Expected behavior Putting §r at the beginning should make the text non italic.

Proxy environment git:Waterfall-Bootstrap:1.18-R0.1-SNAPSHOT:ba3bbcc:483

Minecraft versions used Client version 1.17.1

LaserSlime avatar May 15 '22 10:05 LaserSlime

This is a client side behaviour. Custom item names are always shwon in italic (e.g. when renaming an item with an anvil). The only possibility to suppress this is by explicitly set the italic property of the component to false. The §r is not achieving this goal.

Exceptionflug avatar May 16 '22 08:05 Exceptionflug

But i'm very sure putting §r at the beginning works with bukkit itemstacks.

LaserSlime avatar May 20 '22 15:05 LaserSlime

If it works, then this is custom implemented behaviour on the bukkit end.

Exceptionflug avatar Jun 07 '22 08:06 Exceptionflug

If it works, then this is custom implemented behaviour on the bukkit end.

This isn't a custom Bukkit behaviour, just standard vanilla chat formatting, but it seems it might not apply if you're using a message component.

Though, on this note, we're experiencing this when migrating a BungeeCord plugin to Velocity, in this case using Cirrus. Items appear completely fine on BungeeCord, but the same menu configuration on Velocity causes them to be italicized:

BungeeCord: Velocity:

lewisakura avatar Jun 07 '22 11:06 lewisakura

Same issue here ...

SwartZCoding avatar Oct 19 '22 17:10 SwartZCoding

Hi this actually seems to be an issue, I will look into this.

KotlinFactory avatar Nov 15 '22 14:11 KotlinFactory

UP

remazil avatar Jul 03 '23 10:07 remazil

This is finally fixed with Protocolize v2.3.3. Thank you for you patience.

Exceptionflug avatar Jan 03 '24 19:01 Exceptionflug