Logger icon indicating copy to clipboard operation
Logger copied to clipboard

Server Placeholder not working for player joins Velocity

Open Aiidoneus opened this issue 1 year ago • 4 comments

Describe the bug From what I can tell, the %server% placeholder doesn't work for Player Login logging

To Reproduce Steps to reproduce the behavior:

  1. Try logging "Player Login" and see the placeholder not working
  2. See in the logs it printing [%server%] rather than the actual server

Expected behavior Should display what server they have connected too.

The placeholder does work for "Player Leave" and other things like "Player Commands".

Screenshots N/A

Server & Version (please complete the following information):

  • Logger Version: Logger-1.8.0.11.jar
  • Server Type: Velocity-3.2.0-SNAPSHOT-294.jar

Aiidoneus avatar Dec 05 '23 23:12 Aiidoneus

plz send dump file to us /logger dump

DICEALPHAHU avatar Dec 11 '23 08:12 DICEALPHAHU

plz send dump file to us /logger dump

This is not a thing on Velocity version of logger. From what I can tell, it is only a spigot thing.

https://github.com/ExceptedPrism3/Logger/blob/Improving/Logger-Spigot/src/main/java/me/prism3/logger/commands/subcommands/Dump.java

Aiidoneus avatar Dec 11 '23 10:12 Aiidoneus

Looking at this, doesn't look like any of the replacers were ever added for PostLogin Event for %sever% See as an example: https://github.com/ExceptedPrism3/Logger/blob/a02a383fd47122edf47bdd77051b5925e26b9966/Logger-Velocity/src/main/java/me/prism3/loggervelocity/events/OnLogin.java#L51C74-L51C74

I see it is added on the Disconnected event https://github.com/ExceptedPrism3/Logger/blob/a02a383fd47122edf47bdd77051b5925e26b9966/Logger-Velocity/src/main/java/me/prism3/loggervelocity/events/OnLeave.java#L45C17-L45C17

This might just have been forgotten? Or is there a different reason?

Aiidoneus avatar Dec 11 '23 11:12 Aiidoneus

@ExceptedPrism3

DICEALPHAHU avatar Dec 11 '23 18:12 DICEALPHAHU