ExcelDna icon indicating copy to clipboard operation
ExcelDna copied to clipboard

Align ExcelDnaDoc build with new ExcelDna.AddIn build

Open govert opened this issue 8 years ago • 8 comments

The ExcelDnaDoc package (http://mndrake.github.io/ExcelDnaDoc/index.html and https://github.com/mndrake/ExcelDnaDoc) provide automatic help file generation for Excel-DNA add-ins. It also installs some post-build events (and assumes that these run before the ExcelDna.AddIn build events).

We need to check how it is impacted by the new ExcelDna.AddIn build targets approach, and whether the package needs to be updated to align the build steps from ExcelDnaDoc with ExcelDna.AddIn.

@mndrake might be able to able to help, otherwise it might be suggested as a pull request to the ExcelDnaDoc project.

govert avatar Sep 15 '15 21:09 govert

I can try to take a look, but I don't have an updated windows build environment at the moment, since I've been focused more on Mono (OS X/Linux) if I have done anything in C#/F#. I'll try to get a VM setup to test. Otherwise I definitely would merge a pull request if someone could review changes needed. @govert let me know if you ever wanted to pull ExcelDnaDoc functionality under the umbrella of the Excel-DNA group.

mndrake avatar Sep 17 '15 18:09 mndrake

Thanks Dave - OK, we'll pull the ExcelDnaDoc into the Excel-DNA organization and take it from there. It's a really cool extension!

govert avatar Sep 18 '15 07:09 govert

Hi @govert and @mndrake, I'd like to work on this issue as well as https://github.com/mndrake/ExcelDnaDoc/issues/9.

Right now, the Excel-DNA organization has a fork of ExcelDnaDoc which is 4 commits behind mndrake:master.

What is the approach you'd like to follow? Continue adding fixes to @mndrake original repo, and eventually sync up? If that's the case, @govert could you give me write access to the fork please, so I can keep it in sync?

Alternatively, we could delete the fork, and have @mndrake effectively move his repo to the org and be given write access, of course - which I have the impression that is what he meant when he said:

let me know if you ever wanted to pull ExcelDnaDoc functionality under the umbrella of the Excel-DNA group

augustoproiete avatar Oct 08 '17 14:10 augustoproiete

@augustoproiete That's great - you should have write access to the fork now, to at least sync it up. @mndrake can advise on what structure he would prefer going forward.

govert avatar Oct 08 '17 14:10 govert

Perfect. Thanks @govert. The fork inside the org is now in sync.

augustoproiete avatar Oct 08 '17 14:10 augustoproiete

@govert if it's alright with you. I suggest deleting the fork of ExcelDnaDoc in the Excel-DNA organization and I will just change owners of the original repo to Excel-DNA, which is what @augustoproiete sugessted above. That should insure any outstanding issues and other items transfer over. Also I will make a new repo with just a readme referencing the new location in case anyone stumbles on it and needs to be redirected. I shouldn't need to change ownership of anything on NuGet other than a note that future releases will be under the main Excel-DNA tag.

I spend more time in Python and JavaScript these days than .Net and Excel so appreciate the help in maintaining if people find this useful.

mndrake avatar Oct 08 '17 15:10 mndrake

@mndrake OK - I've deleted it and I think you should now have permissions under Excel-DNA.

govert avatar Oct 08 '17 18:10 govert

It's moved over now. I tried to fix references to anything pointing to mndrake.github.io documentation, but I did not have permissions to correct.

mndrake avatar Oct 08 '17 18:10 mndrake