ExcelDna icon indicating copy to clipboard operation
ExcelDna copied to clipboard

` ExplicitExports="true"` doesn't seem to work

Open fandrei opened this issue 6 years ago • 3 comments

I have an ExplicitExports="true" option in the definition of my ExternalLibrary element; however, I still see lots of messages like this in the Excel-Dna debug log:

Excel-Dna: ExcelDna.Integration Information: 1 : 
Excel-Dna: Method not registered - unsupported signature, abstract or generic: 'AddIn.ShutDown'

Excel-Dna v0.34.6

fandrei avatar Feb 08 '19 21:02 fandrei

@fandrei Could you post the contents of the .dna file here and/or reproduce this behavior in a sample project we can download and test?

augustoproiete avatar Feb 08 '19 23:02 augustoproiete

It looks like the information-level logging will be done for all public static methods that will not be registered, including ones not registered due to ExplicitExports=false. The logging logic can certainly be improved here: https://github.com/Excel-DNA/ExcelDna/blob/cff2f774f1c8d5eb0d9f186e2dbe461ea48eb639/Source/ExcelDna.Integration/AssemblyLoader.cs#L115-L155

govert avatar Feb 10 '19 09:02 govert

@govert I can improve it, what changes do you suggest? From my side - messages about ignored methods and types should be of Verbose level rather than Information.

fandrei avatar Apr 01 '19 22:04 fandrei