amr-wind icon indicating copy to clipboard operation
amr-wind copied to clipboard

Actuator Disk TODO's

Open psakievich opened this issue 2 years ago • 6 comments

  • [x] Remove density as an actuator specific input #640
  • [x] Default num_blades to 3 for Joukowksy #635
  • [x] Consolidate syntax for num_points_r #635
  • [x] Input as TSR or RPM instead of omega #645
  • [x] Output TSR in ncfile #635
  • [ ] Make it work with mesh mapping #647
  • [ ] Create file reads for the table of look up quantities
  • [x] Add f_theta and f_z output to ncfile #635
  • [x] Add a "reasonable" default for vortex_core_size (Maybe 10-15% of rotor diameter?) #645
  • [ ] Add a "disktype" flag to ncfile output.
  • [x] Add power output to ncfile #666
  • [ ] Add power calculation for UnifCtDisk (see @michaeljbrazell branch for a version of the calculation, maybe generalize it)
  • [ ] Add time-history of turbine yaw output to ncfile (c.f. yaw controller changes from HFM Q4)

psakievich avatar Jun 14 '22 17:06 psakievich

@neilmatula and I are realizing that the actuator_src_term[x,y] output is dependent on mesh resolution, which makes it hard to compare against literature. So I added f_theta and f_z output to this list to help with validation.

Lawrence

lawrenceccheung avatar Jun 15 '22 19:06 lawrenceccheung

Sorry, adding one more minor thing to the list. Since it seems like vortex_core_size has an impact on the comparisons (at least with Sorensen's cases), we should probably give it a reasonable value to start with if people don't have any idea what it should be.

Lawrence

lawrenceccheung avatar Jun 16 '22 21:06 lawrenceccheung

And one more minor thing while I'm thinking about it. Was just thinking it would be handy to include a diskType flag to the ncfile to indicate whether it's a UniformCtDisk or JoukowskyDisk type. Just a minor convenience thing, but I might use it in the postprocessing scripts so I can tell whether to expect things like TSR output or not.

Lawrence

lawrenceccheung avatar Jun 21 '22 17:06 lawrenceccheung

@neilmatula and @ndevelder can you update anything you've done on this issue?

psakievich avatar Aug 03 '22 16:08 psakievich

@psakievich Done! I checked the Input TSR and vortex_core_size boxes.

neilmatula avatar Aug 03 '22 16:08 neilmatula

This issue is stale because it has been open 30 days with no activity.

github-actions[bot] avatar May 06 '23 02:05 github-actions[bot]

@psakievich, @neilmatula, @lawrenceccheung do we still need to keep this open? I see a bunch has been done already.

marchdf avatar Jun 26 '24 15:06 marchdf