amr-wind icon indicating copy to clipboard operation
amr-wind copied to clipboard

Fine ABL stats

Open mbkuhn opened this issue 4 months ago • 1 comments

Summary

Path laid out for this upgrade

  • [x] add input parameter to FieldPlaneAveragingFine that can limit the "finest level" to compute averages on
  • [x] replace FieldPlaneAveraging with FieldPlaneAveragingFine
  • [ ] pass regression tests with "finest level" set to 0 in all of the places that used to feature FieldPlaneAveraging
  • [ ] update second order, third order moment calculations to be suited to finer levels (add level masking, interpolation)
  • [ ] add unit tests for second order, third order moment calculations on finer levels
  • [ ] update instances with "finest level" set to 0 to use finer levels, either by default or by user input (including ABLStats)
  • [ ] add new regression or unit test for new capability

Pull request type

Please check the type of change introduced:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

Checklist

The following is included:

  • [ ] new unit-test(s)
  • [ ] new regression test(s)
  • [ ] documentation for new capability

This PR was tested by running:

  • the unit tests
    • [ ] on GPU
    • [ ] on CPU
  • the regression tests
    • [ ] on GPU
    • [ ] on CPU

Additional background

Issue Number: closes #1790, closes #1041

mbkuhn avatar Dec 12 '25 17:12 mbkuhn

something is off with the ghost cells in differences between the two implementations

mbkuhn avatar Dec 12 '25 19:12 mbkuhn

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jan 12 '26 03:01 github-actions[bot]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Feb 13 '26 03:02 github-actions[bot]