amr-wind icon indicating copy to clipboard operation
amr-wind copied to clipboard

Contradictory input file behavior possible for ABLMeanBoussinesq

Open mbkuhn opened this issue 5 months ago • 0 comments

Bug description

In ABLMeanBoussinesq.cpp, the parser checks for the existence of "read_temperature_profile" and never uses the value of it. This means that the argument "read_temperature_profile" could be set to false but have the effect of being set to true.

https://github.com/Exawind/amr-wind/blob/main/amr-wind/equation_systems/icns/source_terms/ABLMeanBoussinesq.cpp#L39

Either the parser should read the value of "read_temperature_profile" or that argument should be deprecated and the parser should just look for the existence of "tprofile_filename".

This bug was found by looking at the code, not during a run.

mbkuhn avatar Sep 06 '24 16:09 mbkuhn