Elouan Martinet

Results 121 comments of Elouan Martinet

Is there anyone that can add the necessary unit test? I'm not able to sign the CLA so I can't contribute myself.

It seems to work on the `fade_in_slide_out` stages (the default) but not on others.

Failed tests were added in 810da1a7023ec87e3fa644499a655740c01baaf7 and 28ac6c00e6f61d40f082af3ae3db380d7951acee, both commits were made after the regression was introduced. EDIT: added `mouse=a` on these tests since it was checking with the buggy...

@bfredl, I rely on this weird behavior, an alternative would be to make it optional. Though `help dev` says `Backwards compatibility is a feature.`. You might want to check the...

@bfredl, I have edited the function to return true when mouse is empty, is it ok or should I explicitly check the case where it contains `n` but not `v`?

If going into that other direction, I think the function would be: ```c /// Check that mouse support is enabled for visual mode static bool mouse_supports_visual(void) { return p_mouse[0] ==...

The test suite failing on FreeBSD works locally on Linux and seems to work on OpenBSD too.

I fixed the linting error. (It appears that many files I have not edited are failing when running `clint-full` locally)

I noticed that this patch doesn't fix the whole behavior. Double click is also to be considered.

This PR is still on my mind, as I self build Neovim since two years. But there are other fixes needed, for example for double-click. I just need to find...