OneScript icon indicating copy to clipboard operation
OneScript copied to clipboard

fix #1404: исправлено ЧтениеJSON.Пропустить() +тесты

Open Mr-Rm opened this issue 1 year ago • 3 comments

  1. Исправлено ЧтениеJSON.Пропустить() для массивов и объектов, имеющих вложенные структуры.
  2. При достиженнии конца JSON текущее состояние устанавливается в ТипЗначенияJSON.Ничего (соответственно 1С)

Mr-Rm avatar May 16 '24 10:05 Mr-Rm

Обзор

Внесены изменения в класс JsonReaderInternal в файле JSONReader.cs, включая добавление свойства Finished и его использование в методах и свойствах класса. В тестовом файле test-json_reader.os добавлены новые тестовые процедуры для проверки пропуска значений и структур JSON, таких как массивы и объекты с вложенными элементами.

Изменения

Файлы Краткое описание изменений
src/.../Library/Json/JSONReader.cs Добавлено свойство Finished, обновление его в методе Read, добавлены проверки свойства в свойствах CurrentValue, CurrentJsonTokenType и CurrentValueType. Упрощён метод Skip.
tests/json/test-json_reader.os Добавлены процедуры тестирования пропуска значений, массивов, незавершённых массивов, массивов с вложенными элементами и объектов с вложенными элементами.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 16 '24 10:05 coderabbitai[bot]

В 1.x? не в develop?

EvilBeaver avatar May 17 '24 09:05 EvilBeaver

Этот PR в 1.x, но в develop тоже надо.

Mr-Rm avatar May 17 '24 11:05 Mr-Rm

@coderabbitai review

EvilBeaver avatar May 21 '24 15:05 EvilBeaver

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot] avatar May 21 '24 15:05 coderabbitai[bot]