happy_hacktoberfest_19 icon indicating copy to clipboard operation
happy_hacktoberfest_19 copied to clipboard

Secret Floof Portal to Happiness Added

Open Rendamage opened this issue 5 years ago • 4 comments

Need to add links to the events drop down but currently can view with a hard link.

Rendamage avatar Oct 21 '19 15:10 Rendamage

Hiya @Rendamage , thanks for this. This PR is deffo an improvement! Can you change your image src links so they're not pointing at your C drive? There's no need to include the C drive part in the link, if your image is residing in the images folder, you can just point to that! :zap: :smiley: I recommend that you rebase before you make your changes aswell just in case you've missed anything.

Evie-Skinner18 avatar Oct 22 '19 17:10 Evie-Skinner18

Hi Evie,

Thanks for the advice. Will do.

All the best,

Renos

Get Outlook for Androidhttps://aka.ms/ghei36


From: Evie Skinner [email protected] Sent: Tuesday, October 22, 2019 6:29:34 PM To: Evie-Skinner18/happy_hacktoberfest_19 [email protected] Cc: Rendamage [email protected]; Mention [email protected] Subject: Re: [Evie-Skinner18/happy_hacktoberfest_19] Secret Floof Portal to Happiness Added (#219)

Hiya @Rendamagehttps://github.com/Rendamage , thanks for this. This PR is deffo an improvement! Can you change your image src links so they're not pointing at your C drive? There's no need to include the C drive part in the link, if your image is residing in the images folder, you can just point to that! ⚡️ 😃 I recommend that you rebase before you make your changes aswell just in case you've missed anything.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Evie-Skinner18/happy_hacktoberfest_19/pull/219?email_source=notifications&email_token=ANKBVTOI6UXP6DOJ46BVK5LQP4Z75A5CNFSM4JC7CV5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6RVOQ#issuecomment-545069754, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANKBVTLUQDI5CZNNUUIWS63QP4Z75ANCNFSM4JC7CV5A.

Rendamage avatar Oct 26 '19 11:10 Rendamage

@Rendamage, would you like to submit a fixed and rebased pull request, or would you like me to do it?

@Rendamage, would you like to submit a fixed and rebased pull request, or would you like me to do it?

Hi Isaac, Could you fix this for me. I am not sure I would be able to do it without causing another merge conflict. A good lesson for me at least to remember to submit my code often and to use ../ for my images.

Rendamage avatar Nov 15 '19 14:11 Rendamage