Evidlo
Pressure sensing on Windows, dynamic monitor selection
Builds upon @DCS-87's implementation of pressure sensing on Windows.
Dynamically changes the monitor to output to based on mouse position. This is now on by default and is overridden when the --monitor or --region tags are used.
Additionally, the program can now be exited using Ctrl-C, which did not use to work. The only option was to close the console which made restarting a pain.
I think these changes are significant enough to be worth publishing a new version to PyPi!
Thanks for putting the work into this. I'd be happy to merge in support for pressure on Windows, but this needs to be cleaned up quite a bit.
- I'd much rather the argument be called
--windowsor something like that.--penisn't very descriptive. pen.pyis rather messy. There are lots of unused constants, inconsistent coding style (e.g. camelcaseapplyPen). This file needs a refactor.- Remove the automonitor feature from the PR. We can talk about adding this behavior in an issue, but it's easier if this was removed for now.
Yeah it's messy because I don't know much about coding, that is just me and google being happy to get it working at all. I'll let someone else take a crack at refactoring that :) I do like the dynamic monitor selection though.
Yeah it's messy because I don't know much about coding, that is just me and google being happy to get it working at all. I'll let someone else take a crack at refactoring that :) I do like the dynamic monitor selection though.
I understand. I have to keep maintainability in mind (been maintaining this for 5 years), so I can't merge contributions in just because they work.
By the way, PRs and feedback on them is a great way to gain programming experience.
Thanks for doing this @aklevans, I had a go at cleaning this up a little bit in #97. Happy to do a little more work to get this merged in as it'd be quite useful to me.
Thanks to you or @DCS-87, whoever did the pressure sensitivity code, I mostly pulled it directly with some minor cleanup.
