Vulkan.NET icon indicating copy to clipboard operation
Vulkan.NET copied to clipboard

Inconsistency with Vulkan API vkCmdSetFragmentShadingRateKHR

Open jayrulez opened this issue 2 years ago • 2 comments

There seems to be an issue here:

https://github.com/EvergineTeam/Vulkan.NET/blob/2e1290c2c3f4e3cf81c5307bd0e84c3224b3b08e/VulkanGen/Evergine.Bindings.Vulkan/Generated/Commands.cs#L2423

The vulkan API is

// Provided by VK_KHR_fragment_shading_rate
void vkCmdSetFragmentShadingRateKHR(
    VkCommandBuffer                             commandBuffer,
    const VkExtent2D*                           pFragmentSize,
    const VkFragmentShadingRateCombinerOpKHR    combinerOps[2]);

taking two VkFragmentShadingRateCombinerOpKHR

jayrulez avatar Jun 14 '22 17:06 jayrulez

I have a fix for this in my fork: https://github.com/jayrulez/Bulkan.Generator/commit/2dcdf05451f6aa4be91bfa2d310ad2e36776fc1f

Perhaps you want it to use it or fix it differently.

jayrulez avatar Jun 15 '22 03:06 jayrulez

Hi,

I'm going to review this fix before make this changes.

Thank you for your help!

jcant0n avatar Sep 13 '22 15:09 jcant0n