Daft icon indicating copy to clipboard operation
Daft copied to clipboard

feat(io): add ignore error for Parquet/CSV/lance/iceberg;

Open Jay-ju opened this issue 2 months ago • 2 comments

Changes Made

Related Issues

Checklist

  • [ ] Documented in API Docs (if applicable)
  • [ ] Documented in User Guide (if applicable)
  • [ ] If adding a new documentation page, doc is added to docs/mkdocs.yml navigation
  • [ ] Documentation builds and is formatted properly

Jay-ju avatar Oct 18 '25 06:10 Jay-ju

@everettVT Please take a look at the content of this PR when you have time.

Jay-ju avatar Oct 21 '25 05:10 Jay-ju

Codecov Report

:x: Patch coverage is 71.81208% with 42 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 72.34%. Comparing base (de40ceb) to head (0e6f867). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-local-execution/src/sources/scan_task.rs 65.45% 19 Missing :warning:
src/daft-scan/src/glob.rs 77.19% 13 Missing :warning:
daft/io/lance/lance_scan.py 55.00% 9 Missing :warning:
src/common/file-formats/src/file_format_config.rs 80.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5418      +/-   ##
==========================================
+ Coverage   72.14%   72.34%   +0.19%     
==========================================
  Files         964      964              
  Lines      125091   124706     -385     
==========================================
- Hits        90252    90220      -32     
+ Misses      34839    34486     -353     
Files with missing lines Coverage Δ
daft/io/_csv.py 100.00% <ø> (ø)
daft/io/_parquet.py 87.50% <ø> (ø)
daft/io/iceberg/_iceberg.py 90.32% <100.00%> (ø)
daft/io/iceberg/iceberg_scan.py 76.16% <100.00%> (+0.13%) :arrow_up:
daft/io/lance/_lance.py 91.04% <ø> (ø)
src/daft-scan/src/builder.rs 22.42% <100.00%> (+0.48%) :arrow_up:
src/daft-scan/src/lib.rs 75.02% <100.00%> (+0.18%) :arrow_up:
src/common/file-formats/src/file_format_config.rs 60.71% <80.00%> (+0.50%) :arrow_up:
daft/io/lance/lance_scan.py 88.60% <55.00%> (-1.40%) :arrow_down:
src/daft-scan/src/glob.rs 89.51% <77.19%> (-2.17%) :arrow_down:
... and 1 more

... and 15 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 21 '25 10:10 codecov[bot]

@Jay-ju, checking to see if you are able to push this through based on the review comments. Thanks!

madvart avatar Dec 02 '25 19:12 madvart

@Jay-ju, checking to see if you are able to push this through based on the review comments. Thanks!

@madvart @desmondcheongzx Thank you for your patience. Could you please help check this PR again? Thank you.

Jay-ju avatar Dec 15 '25 08:12 Jay-ju