Daft icon indicating copy to clipboard operation
Daft copied to clipboard

`ddof` argument to `stddev`

Open MarcoGorelli opened this issue 6 months ago • 8 comments

Is your feature request related to a problem?

narwhals

Describe the solution you'd like

daft.col('a').stddev(ddof=1)

Describe alternatives you've considered

something like

            n_rows = expr.count()
            return expr.stddev() * ((n_rows - 1).sqrt() / (n_rows - 1))

but then I wouldn't be able to evaluate that in over context

Additional Context

No response

Would you like to implement a fix?

No

MarcoGorelli avatar Jun 01 '25 14:06 MarcoGorelli

Hey, Will love to work on this.

venkateshdb avatar Jul 05 '25 15:07 venkateshdb

Hey @venkateshdb, just saw that you left a comment. Feel free to knock this out!

desmondcheongzx avatar Aug 04 '25 16:08 desmondcheongzx

@venkateshdb still interested? Thanks for taking a look.

rchowell avatar Aug 05 '25 23:08 rchowell

Yes, @rchowell I have started working on this. I was stuck on the setup part, but that's resolved now.

venkateshdb avatar Aug 05 '25 23:08 venkateshdb

@venkateshdb any updates here? I will re-assign if you are no longer working on this. Thanks!

rchowell avatar Sep 30 '25 16:09 rchowell

@rchowell, Almost done with it https://github.com/Eventual-Inc/Daft/pull/4949, got busy with other stuff, will get this done by this weekend.

venkateshdb avatar Sep 30 '25 17:09 venkateshdb

Hi @venkateshdb just checking in, how is it going?

malcolmgreaves avatar Oct 28 '25 03:10 malcolmgreaves

@malcolmgreaves. Sorry for the delay, Got busy with other stuff, will make sure to update the PR this week.

venkateshdb avatar Oct 28 '25 14:10 venkateshdb