Daft icon indicating copy to clipboard operation
Daft copied to clipboard

feat: add python install editable

Open Jay-ju opened this issue 8 months ago • 1 comments

Changes Made

Related Issues

Checklist

  • [ ] Documented in API Docs (if applicable)
  • [ ] Documented in User Guide (if applicable)
  • [ ] If adding a new documentation page, doc is added to docs/mkdocs.yml navigation
  • [ ] Documentation builds and is formatted properly (tag @/ccmao1130 for docs review)

Jay-ju avatar Apr 21 '25 03:04 Jay-ju

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.43%. Comparing base (771790e) to head (2d0b0ed). Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4223      +/-   ##
==========================================
+ Coverage   78.24%   78.43%   +0.18%     
==========================================
  Files         799      798       -1     
  Lines      104968   104704     -264     
==========================================
- Hits        82134    82126       -8     
+ Misses      22834    22578     -256     

see 14 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 21 '25 03:04 codecov[bot]

@jaychia @colin-ho Can a rebase button be added to the pipeline? I'm not sure if the failure of the use case here is due to my PR or the lack of rebase. Also, if you have time, could you help take a look at the changes I made here?

Jay-ju avatar Jun 04 '25 08:06 Jay-ju

You should be able to rebase locally and do a force push!

Also thanks for the PR -- is Daft not already installed in editable mode for local development with make build? That seems surprising to me.

jaychia avatar Jun 05 '25 03:06 jaychia

You should be able to rebase locally and do a force push!

Also thanks for the PR -- is Daft not already installed in editable mode for local development with make build? That seems surprising to me.

@jaychia Sorry, I found it was a problem with my usage method. Ignore it. Thank you.

Jay-ju avatar Jun 08 '25 08:06 Jay-ju